-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support firesim distributed elaboration #872
Conversation
I understand why the BootROM change breaks things. I'll go fix the makefiles. Actually, it looks like the firesim changes in firesim#651 are required for the FireSim regressions that are run as part of Chipyard. For some reason, I thought that you didn't regress FireSim in Chipyard but I don't know where I got that idea. Should I bump FireSim to point to the firesim#651 PR? If you guys use WithBootROM outside of FireSim, that may also need to be adjusted so that the bootrom file can be found in the TargetDir of the generator. |
Ok. Now that I'm past the FireSim failures, I see the breakages I thought I might see in |
I think this could be clearer... but I normally refer to target software.
Yup!
If you want to copy the bootrom files from testchipip, you can do that either in |
w00t CI is passing everything except the FireSim is on master check! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments here and there. Overall looks good.
* only specifically identified artifacts use non-default strategies * fallthrough uses default strategies (that will error) * adds a custom strategy that prefers a non-rocketchip artifact (notRocketMergeStrategy) * needed for chipard/generators/utilities/src/main/resources/csrc/emulator.cc so that the ChipYard version is used instead of the one from RC * adds (useRocketMergeStrategy) that prefers the RC artifact * we want to use vsrc/SimDTM.v from rocketchip, not riscv-sodor Needed for firesim/firesim#651
common.mk looks for fd but falls back to a slower option using find. when it isn't found, don't print that it isn't found to the output because it is okay for it not to be found.
for FireSim chipyard as top, it gets run_scala_main and run_main from chipyard's variables.mk
It was confusing when I hit it. A little help without having to go sift through the scala to find the assertion goes a long way.
not needed in Chipyard, only FireSim
b21ae89
to
f081988
Compare
f081988
to
dafacf6
Compare
Closing stale PR |
Related issue: firesim/firesim#646
This is #716 re-incarnated using a local branch so that the CI will run (and rebased several months forward).
Type of change: other enhancement
Impact: rtl change & infrastructure change
Do you guys consider changes to the makefiles as 'software' change or is that target software?
RTL change removes the FireSim/firechip duplication of
WithBootROM
and insteadRelease Notes
chipyard.Generator
--legacy-config
parser. Error without message was confusing.fd
, if it isn't found, makefiles fall back tofind
.gen-replace-rtl-script
target