-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fat jar's to remove SBT invocations #1375
Conversation
17558d0
to
5733aa3
Compare
5733aa3
to
8c8820a
Compare
@@ -86,8 +109,6 @@ lazy val hardfloat = (project in rocketChipDir / "hardfloat") | |||
.settings(commonSettings) | |||
.settings( | |||
libraryDependencies ++= Seq( | |||
"org.scala-lang" % "scala-reflect" % scalaVersion.value, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cleanup (these deps aren't needed)
Can you check this ?
|
In a clean repo, after running the setup.
|
Closing since #1362 solves the initial issue I was trying to solve. I'll add this after the release if time permits. |
This PR can be independently merged in separate from FireSim (see https://github.com/firesim/firesim/actions/runs/5010945519) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to merge once the CI passes.
Since the SBT thin client is brittle (can sometimes not read in
SBT_OPTS
, and other issues in the past), this PR will instead remove the thin client feature and instead build a fat jar to avoid SBT invocations. This also helps future work in distributing Chisel elaboration to multiple hosts (i.e. just needing to copy the fat jar to generate Verilog in parallel on different machines).This repurposing a lot of the work that was done in: #872 and firesim/firesim#651 with inspiration from firesim/firesim#1390
src/main/rsrc/Makefile
and PrjB also has a file in the same path it would error.build.sbt
cleanup to avoid other misc. sbt assembly errors. The deps removed are not needed.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?