Bump Rocketchip to June 2020 for Tile changes #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryz123
force-pushed
the
rc-retile
branch
2 times, most recently
from
06dd012
to
b061e67
Compare
colinschmidt
requested changes
Jun 18, 2020
|
|
||
| import testchipip.{DromajoHelper} |
| if (cfg.fLen >= 64) | ||
| addSuites(env.map(rv64ud)) | ||
| p(TilesLocated(InSubsystem)).find(_.tileParams.hartId == 0).map { | ||
| case tp: RocketTileAttachParams => { |
There was a problem hiding this comment.
These seem quite redundant to me but that refactor is definitely for another PR.
There was a problem hiding this comment.
I agree with both statements
colinschmidt
approved these changes
Jun 18, 2020
|
Are you planning to test this in FireSim? |
I can push a rocket config through, but I wasn't planning on regenerating AGFIs, since no FireSim changes were necessary. |
|
Considering there are 234 new commits i want to see an AGFI regeneration + linux boots. |
This was referenced Jun 23, 2020
|
I've been placated. I too am always down for the net negative code change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rocketchip bump to grab generic Tile instantiation changes.
Related issue:
chipsalliance/rocket-chip#2504
Type of change: new feature
Impact: rtl change
Release Notes
XTilesKeyare removed everywhereTilesLocatedkeySystem/Subsystemrenamed toChipyardSystem/ChipyardSubsystemto avoid name conflict with RCWithControlCoreremoved (this was duplicate ofWithNSmallCores).ChipyardSubsystemnow uses genericHasTilesto instantiate tilesSubmodule bumps: