-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Chisel6 for RTL-sim/VLSI/FPGA flows #1854
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
838cd9a
Remove hwacha/esp-tools
jerryz123 c8c176b
Remove sha3 due to no chisel6 compatibility
jerryz123 83c56ec
Bump mempress to modern chisel
jerryz123 58dc407
Rename dsptools/fixedpoint submods to chisel3
jerryz123 b37e550
Add chisel6 fixedpoint/dsptools
jerryz123 718f197
Add standalone midas-targetutils
jerryz123 0d51cc3
Bump chisel6-dsptools
jerryz123 c2d4180
Move chipyard stage to separate directory
jerryz123 4b28789
Add chisel6 stage
jerryz123 2be92bc
Update chisel6 chipyard-stage API
jerryz123 ab077ef
Add stage/stage-chisel3 to makefile source-finder
jerryz123 295435a
Bump fpga-shells to fix chisel6-breaking API
jerryz123 daf4b64
Update fpga-flow to remove chisel6-incompatible APIs
jerryz123 39092e9
Switch RTL-sim/FPGA/VLSI flows to chisel6
jerryz123 ab78bbe
Precisely define firesim source directories
jerryz123 743681b
Dedup apache dependencies in build.sbt
jerryz123 3cda03a
Combine chipyard-full-flow into one job
jerryz123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -119,29 +119,6 @@ jobs: | |
conda activate ${{ env.conda-env-name-no-time }}-$(date --date "${{ env.workflow-timestamp }}" +%Y%m%d)-riscv-tools | ||
.github/scripts/check-commit.sh | ||
|
||
tutorial-setup-check: | ||
name: tutorial-setup-check | ||
needs: [setup-complete] | ||
if: needs.change-filters.outputs.needs-rtl == 'true' | ||
runs-on: as4 | ||
steps: | ||
- name: Delete old checkout | ||
run: | | ||
ls -alh . | ||
rm -rf ${{ github.workspace }}/* || true | ||
rm -rf ${{ github.workspace }}/.* || true | ||
ls -alh . | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
- name: Git workaround | ||
uses: ./.github/actions/git-workaround | ||
- name: Create conda env | ||
uses: ./.github/actions/create-conda-env | ||
- name: Check that the tutorial-setup patches apply | ||
run: | | ||
conda activate ${{ env.conda-env-name-no-time }}-$(date --date "${{ env.workflow-timestamp }}" +%Y%m%d)-riscv-tools | ||
scripts/tutorial-setup.sh | ||
|
||
documentation-check: | ||
name: documentation-check | ||
needs: [setup-complete] | ||
|
@@ -800,29 +777,6 @@ jobs: | |
group-key: "group-peripherals" | ||
project-key: "chipyard-llcchiplet" | ||
|
||
chipyard-sha3-run-tests: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are SHA3 and Mempress getting removed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They use too many deprecated chisel2 APIs. |
||
name: chipyard-sha3-run-tests | ||
needs: prepare-chipyard-accels | ||
runs-on: as4 | ||
steps: | ||
- name: Delete old checkout | ||
run: | | ||
ls -alh . | ||
rm -rf ${{ github.workspace }}/* || true | ||
rm -rf ${{ github.workspace }}/.* || true | ||
ls -alh . | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
- name: Git workaround | ||
uses: ./.github/actions/git-workaround | ||
- name: Create conda env | ||
uses: ./.github/actions/create-conda-env | ||
- name: Run tests | ||
uses: ./.github/actions/run-tests | ||
with: | ||
group-key: "group-accels" | ||
project-key: "chipyard-sha3" | ||
|
||
chipyard-gemmini-run-tests: | ||
name: chipyard-gemmini-run-tests | ||
needs: prepare-chipyard-accels | ||
|
@@ -1172,7 +1126,6 @@ jobs: | |
all_tests_passed: | ||
name: "all tests passed" | ||
needs: [commit-on-master-check, | ||
tutorial-setup-check, | ||
documentation-check, | ||
chipyard-rocket-run-tests, | ||
chipyard-hetero-run-tests, | ||
|
@@ -1190,7 +1143,6 @@ jobs: | |
chipyard-tethered-run-tests, | ||
chipyard-symmetric-run-tests, | ||
chipyard-llcchiplet-run-tests, | ||
chipyard-sha3-run-tests, | ||
chipyard-gemmini-run-tests, | ||
chipyard-manymmioaccels-run-tests, # chipyard-nvdla-run-tests, | ||
chipyard-prefetchers-run-tests, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do this? I think having it in separate steps makes it easier to read in the UI and makes it clearer what to do when adding to this CI a new task/job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept experiencing failures in the build caching between the two jobs. I can poke around more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update on this?