Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump TestChipIp to improve default serial_tl behavior #1435

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Apr 10, 2023

Previously, a special config fragment was necessary to prevent the chip from generating serial_tl packets during reset. Additionally, this was done using AsyncQueues, instead of just BlockDuringReset.

This changes all designs to block serial_tl while under reset

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123 jerryz123 requested a review from T-K-233 April 13, 2023 17:13
@jerryz123 jerryz123 marked this pull request as ready for review April 13, 2023 17:13
Copy link
Member

@T-K-233 T-K-233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to change the chip config order to:

class ChipLikeQuadRocketConfig extends Config(
  // Set up TestHarness
  
  // Set up I/O

  // Set up tiles

  // Set up clock./reset
)

(io go after tiles)?

This way is cleaner, such that periphery devices (backing mem, uart, spi etc) are added after the core.

@jerryz123
Copy link
Contributor Author

Is it possible to change the chip config order to:

class ChipLikeQuadRocketConfig extends Config(
  // Set up TestHarness
  
  // Set up I/O

  // Set up tiles

  // Set up clock./reset
)

(io go after tiles)?

This way is cleaner, such that periphery devices (backing mem, uart, spi etc) are added after the core.

I think that should be fine, if you do it in another PR.
Is this just for code hygiene, or is there a functional difference due to the order of peripherals w.r.t. cores that you are seeing?

@jerryz123 jerryz123 merged commit 3b303ba into main Apr 18, 2023
@jerryz123 jerryz123 deleted the blockserialtl branch April 18, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants