-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flip serial_tl_clock to be generated off-chip #1445
Conversation
c03bcbb
to
565fb7a
Compare
@harrisonliew You are right, the constraints for the existing vcu118 bringup flow should add a clock input into the chip. However, doing so would cause backwards compatibility issues with anyone who uses that bringup flow for existing chips. And future chips should use a lightweight bringup platform that is yet-to-be implemented anyways. Can we just leave the existing vcu118 setup as is, until the new one is brought up? @abejgonzalez @harrisonliew what do you think? |
I'm fine with this if either 1) the clock direction is selectable (e.g. via a legacy vs. new VCU118 config) or 2) the VCU118 bringup is explicitly disallowed in the documentation for bringup of chips built using Chipyard version >=1.9.1. |
I'm fine with deprecating the current VCU118 bringup flow and just adding to the docs "Hey don't use this for future chips use XYZ flow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0f3ca64
to
c092341
Compare
I've realized supporting bidirectional clock is very useful. |
720cfe6
to
1114b3b
Compare
We don't require the host computer to be x86 (can be RISC-V!)
Previously, the serial_tl_clock is generated on-chip, and passed to the host bringup FPGA. This flips that, so the FPGA must generate the clock.
Follows up on #1435 to improve the serial_tl robustness and ease-of-use.
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?