-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gen-collateral when rebuilding #1342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just change the FIRTOOL recipe to rm -rf $(OUT_DIR)
and list it as a target? That seems less invasive.
In the process, can we also rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks clean. I'll test this once this gets merged.
The prior approach didn't enforce that the collateral directory would be rebuilt. This new approach basically forces |
2e7613e
to
8623e14
Compare
8623e14
to
55950b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The renaming LGTM. Pending reviews from others on the rm -rf
Related PRs / Issues:
This PR addresses #1341.
Removes $(OUT_DIR) which is
gen-collateral
when re-compiling.Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?