Fixes #30638 - replace react-numeric-input with rc-number-input

[yifatmakias]

The rc-input-number is a much simple library and has fewer bugs therefore it should replace the react-numeric-input in the NumericInput react component.

[theforeman-bot]

Issues: #30638

[yifatmakias]

This PR is a blocker PR to:
#7794
#7865

[yifatmakias]

[test foreman]

[sharvit]

Thanks @yifatmakias, works well 👍

Doesn't it going to break to following css files?
https://github.com/theforeman/foreman/blob/2cd4d88297a36d9a43a34a64badb3b7aa18e7d31/webpack/assets/javascripts/react_app/components/CPUCoresInput/cpuCoresInput.scss
https://github.com/theforeman/foreman/blob/ae96cb70130968bdcc8b7a9a9af7edc7c6e0d9a8/webpack/assets/javascripts/react_app/components/hosts/storage/vmware/controller/disk/disk.scss

[yifatmakias]

[test foreman]

[yifatmakias]

This PR is blocked by another PR:
theforeman/foreman-js#198

[coveralls]

Coverage remained the same at 73.795% when pulling ff79968cfcaa57dbef705eb0aa69f20d78c71e27 on yifatmakias:30638 into 85befdd on theforeman:develop.

[yifatmakias]

[test katello]

[sharvit]

Thanks @yifatmakias

[sharvit]

Thanks @yifatmakias

[sharvit]

We could drop the input styles if we could set the input className to form-control.
Unfortunately, the rc-input-number doesn't support custom class names on the input field.

Sent a PR to rc-input-number so they can have this feature:
react-component/input-number#262

Can you please add a comment in the code with a reminder to drop the input styles once merged?

[sharvit]

When I set the disabled prop to true, the hover effect still exists and it looks odd.

[sharvit]

I don't see the glowing effect that we usually have when focused.
try:

@import "~@theforeman/vendor/scss/mixins";

&:focus {
  @include form-control-outline;
}

[houndci-bot]

Unexpected unknown at-rule "@include" at-rule-no-unknown

[sharvit]

Thanks @yifatmakias, looks good and works as expected 👍

[sharvit]

Can we get ack from packaging please?

[ekohl]

Packaging ACK, didn't really look at the actual JS code.

[ekohl]

Still a packaging ack.

[ekohl]

I'd be consistent and also add it here. You may also want to consider sorting the list alphabetically. Those are just some practices I started to use because it's easier to deal with when things get longer and you're searching for something.

[yifatmakias]

@ekohl Added another comma and also sorted alphabetically. Thanks for the review! :)

[ekohl]

LGTM. The tests are still running now, but otherwise I think it can be merged.

[ekohl]

Oh, they finished. @sharvit I'm not sure you gave an ACK or not so leaving the final honors of merging to you.

[sharvit]

Thanks @yifatmakias, looks good and works as expected 👍

Thanks @ekohl, merging.