Skip to content

feat(vendor-core): adds rc-number-input - #198

Merged
sharvit merged 1 commit into
theforeman:masterfrom
yifatmakias:30638
Aug 17, 2020
Merged

sharvit merged 1 commit into
theforeman:masterfrom
yifatmakias:30638

Conversation

@yifatmakias

Copy link
Copy Markdown

Updated Packages

  • root
  • @theforeman/builder
  • @theforeman/test
  • @theforeman/eslint-plugin-foreman
  • @theforeman/stories
  • @theforeman/vendor
  • @theforeman/vendor-dev
  • @theforeman/vendor-core
  • @theforeman/find-foreman

PR Type

  • Bugfix
  • Feature
  • Code style update (whitespace, formatting, missing semicolons, etc.)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other… Please describe:

Description

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR fixes open issues?

  • Yes
  • No

Do you use this PR in another repository?

  • Yes
  • No

@sharvit sharvit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yifatmakias

Comment thread packages/vendor-core/lib/modules.js Outdated
@sharvit

sharvit commented Aug 17, 2020

Copy link
Copy Markdown
Contributor

The eslint issue in the foreman is not related.

@sharvit sharvit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yifatmakias, looks good and works as expected 👍

@sharvit
sharvit merged commit 4135662 into theforeman:master Aug 17, 2020
@sharvit

sharvit commented Aug 17, 2020

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 4.14.0 🎉

The release is available on:

Thank you for your contribution, your foreman-js bot 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants