Skip to content

refactor(vendor-core): remove unused packages from vendor core - #377

Merged
sharvit merged 1 commit into
theforeman:masterfrom
MariaAga:remove-extra-packages
Feb 15, 2022
Merged

sharvit merged 1 commit into
theforeman:masterfrom
MariaAga:remove-extra-packages

Conversation

@MariaAga

@MariaAga MariaAga commented Feb 2, 2022

Copy link
Copy Markdown
Member

removes 'react-numeric-input','react-markdown', 'isomorphic-fetch'

theforeman/foreman#5080 - removed 'react-markdown'
theforeman/foreman#7725 - added 'isomorphic-fetch' but was never merged
theforeman/foreman#7896 - removed 'react-numeric-input'

@MariaAga
MariaAga requested a review from sharvit February 2, 2022 17:33

@sharvit sharvit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MariaAga LGTM

@sharvit

sharvit commented Feb 8, 2022 •

Copy link
Copy Markdown
Contributor

As described here: https://github.com/theforeman/foreman-js/blob/master/docs/managing-vendor-dependencies.md#remove-a-vendor-dependency

Removing a package is similar to updating a package, but we will always describe BREAKING CHANGES in the commit message, and the CI should release a Major version to npm.

I am ok getting it merged as it is because it doesn't actually break anything but might be worth considering anyway just so we keep a clear changelog.

@MariaAga
MariaAga force-pushed the remove-extra-packages branch from bb6deb8 to 5856c63 Compare February 8, 2022 11:24
@MariaAga

MariaAga commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

Thanks! changed the commit message

@sharvit

sharvit commented Feb 10, 2022

Copy link
Copy Markdown
Contributor

Need to change the text in the commit from BREAKING CHANGE to BREAKING CHANGES

removes 'react-numeric-input','react-markdown', 'isomorphic-fetch'

BREAKING CHANGES:
removes 'react-numeric-input','react-markdown', 'isomorphic-fetch'
@MariaAga

Copy link
Copy Markdown
Member Author

breakingPrefix: 'BREAKING CHANGE:',

Should we change this to BREAKING CHANGES as well?

@MariaAga
MariaAga force-pushed the remove-extra-packages branch from 5856c63 to a2cada9 Compare February 10, 2022 18:02
@sharvit

sharvit commented Feb 15, 2022

Copy link
Copy Markdown
Contributor

It's odd, I guess the tool will accept both...

You are welcome to change it in another PR, merging...

@sharvit
sharvit merged commit 0456b7b into theforeman:master Feb 15, 2022
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 10.0.2 🎉

The release is available on:

Thank you for your contribution, your foreman-js bot 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants