Repository navigation
refactor(vendor-core): remove unused packages from vendor core - #377
Conversation
|
As described here: https://github.com/theforeman/foreman-js/blob/master/docs/managing-vendor-dependencies.md#remove-a-vendor-dependency
I am ok getting it merged as it is because it doesn't actually break anything but might be worth considering anyway just so we keep a clear changelog. |
bb6deb8 to
5856c63
Compare
|
Thanks! changed the commit message |
|
Need to change the text in the commit from BREAKING CHANGE to BREAKING CHANGES |
removes 'react-numeric-input','react-markdown', 'isomorphic-fetch' BREAKING CHANGES: removes 'react-numeric-input','react-markdown', 'isomorphic-fetch'
|
Line 75 in 7fa9adb Should we change this to BREAKING CHANGES as well?
|
5856c63 to
a2cada9
Compare
|
It's odd, I guess the tool will accept both... You are welcome to change it in another PR, merging... |
|
🎉 This PR is included in version The release is available on:
Thank you for your contribution, your foreman-js bot 🤖 |
removes 'react-numeric-input','react-markdown', 'isomorphic-fetch'
theforeman/foreman#5080 - removed 'react-markdown'
theforeman/foreman#7725 - added 'isomorphic-fetch' but was never merged
theforeman/foreman#7896 - removed 'react-numeric-input'