Fixes #30288 - replace CPU/Cores/socket input to react comp

[yifatmakias]

No description provided.

[theforeman-bot]

Issues: #30288

[MariaAga]

Thanks Yifat! Snapshots should be replaced and can you add tests for the warning and error states of the component?
Also I think there shouldn't be space between the warning and the cpu input, and instead there should be space between the warning and the next input, you can maybe add a class to the cpu input and add/remove margins

[MariaAga]

Also I think for the warnings it makes sense to take the rest of the Row so can you change 4 to 10?

[yifatmakias]

@MariaAga Thanks for the review.
I fixed the tests and all the comments.
I still need to add more tests and to fix the double space between the input to the alert message.

[coveralls]

Coverage increased (+0.02%) to 73.85% when pulling 4855efb456fcb1448fdb6b22f0d6952d760f0e94 on yifatmakias:30288 into cbf3a1f on theforeman:develop.

[amirfefer]

foreman tests failures look related

[yifatmakias]

@amirfefer Yes I know, I am working on fixing it.

[MariaAga]

Looks like the tests are working now 🎉

[MariaAga]

Can you merge this into 1 object?
fixtures ={ 'should..default...':{}, 'should..warning...':{}, 'should..error...':{}}

[yifatmakias]

[test katello]

[yifatmakias]

[test katello]

[yifatmakias]

[test foreman]

[xprazak2]

Works well on libvirt, I haven't tested ovirt or vmware.

[shiramax]

Thanks @yifatmakias

I see some strange behavior here, every time I increase the socket, the cores also increase and vice versa,
it shouldn't be like that, the cores and socket are completely different attributes.

[yifatmakias]

@shiramax You are definitely right I will figure out the problem and fix this.
Thanks!

[yifatmakias]

[test katello]

[ezr-ondrej]

This works and code looks good.
Thanks a lot, loving this ❤️ 👍

[ezr-ondrej]

@MariaAga, @shiramax were your concerns addressed?

[shiramax]

@ezr-ondrej yes. thanks

I believe all concerns were addressed.