Skip to content

Conversation

@kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 4, 2025

Reverts #10754

I'll fix fundamental issue before merging this

@kdy1 kdy1 added this to the Planned milestone Jul 4, 2025
@kdy1 kdy1 requested a review from magic-akari July 4, 2025 07:49
@kdy1 kdy1 self-assigned this Jul 4, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2025

⚠️ No Changeset found

Latest commit: b726f3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 4, 2025

CodSpeed Performance Report

Merging #10778 will not alter performance

Comparing revert-10754-kdy1/browserslist (b726f3e) with main (d60a611)

Summary

✅ 141 untouched benchmarks

@chenjiahan
Copy link
Contributor

Note: This change affects Rspack's parsing of targets: ['ie 11']

Can you release a new version when you have time? Thanks! ❤️

@kdy1
Copy link
Member Author

kdy1 commented Jul 4, 2025

I need to fix another bug first. I’ll merge this PR after fixing it.

@kdy1
Copy link
Member Author

kdy1 commented Jul 4, 2025

i'll merge this first to unblock

@kdy1 kdy1 marked this pull request as ready for review July 4, 2025 11:27
@kdy1 kdy1 requested review from a team as code owners July 4, 2025 11:27
@kdy1 kdy1 merged commit 7af5824 into main Jul 4, 2025
168 checks passed
@kdy1 kdy1 deleted the revert-10754-kdy1/browserslist branch July 4, 2025 11:27
bvanjoi pushed a commit to bvanjoi/swc that referenced this pull request Jul 4, 2025
@kdy1
Copy link
Member Author

kdy1 commented Jul 4, 2025

@chenjiahan 18311df

@chenjiahan
Copy link
Contributor

Thank you! 👍

@kdy1 kdy1 modified the milestones: Planned, v1.12.10 Jul 7, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants