-
-
Notifications
You must be signed in to change notification settings - Fork 232
feat(deps): update Rspack to v1.4.3 #5532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the @rspack/core dependency from v1.4.2 to v1.4.3 in packages/core/package.json.
- Bumps Rspack core version to v1.4.3
- No other code or tests modified
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
packages/core/package.json:55
- [nitpick] Consider updating the CHANGELOG.md or upgrade notes to include details of the Rspack v1.4.3 update for transparency.
"@rspack/core": "1.4.3",
packages/core/package.json:55
- Ensure that the lockfile (e.g., yarn.lock or package-lock.json) is committed after updating the dependency to prevent version mismatches.
"@rspack/core": "1.4.3",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Syntax Test Target Mismatch
The browser target for the pluginCheckSyntax test was unintentionally changed from 'ie 11' to 'android >= 4.4' when moving configuration to an external file. This significantly alters test behavior as IE 11 requires more aggressive syntax transpilation, potentially reducing the comprehensiveness of syntax checks for older browsers.
e2e/cases/source/source-include/rsbuild.config.ts#L6-L7
rsbuild/e2e/cases/source/source-include/rsbuild.config.ts
Lines 6 to 7 in 2bd3db9
| output: { | |
| overrideBrowserslist: ['android >= 4.4'], |
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
This version breaks |

Summary
update Rspack to v1.4.3
Related Links
https://github.com/web-infra-dev/rspack/releases/tag/v1.4.3
Checklist