Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

update Rspack to v1.4.3

Related Links

https://github.com/web-infra-dev/rspack/releases/tag/v1.4.3

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings July 4, 2025 05:44
@netlify
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 2bd3db9
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68679e9b8669830008e9c52c
😎 Deploy Preview https://deploy-preview-5532--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 78 (🟢 up 13 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the @rspack/core dependency from v1.4.2 to v1.4.3 in packages/core/package.json.

  • Bumps Rspack core version to v1.4.3
  • No other code or tests modified
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)

packages/core/package.json:55

  • [nitpick] Consider updating the CHANGELOG.md or upgrade notes to include details of the Rspack v1.4.3 update for transparency.
    "@rspack/core": "1.4.3",

packages/core/package.json:55

  • Ensure that the lockfile (e.g., yarn.lock or package-lock.json) is committed after updating the dependency to prevent version mismatches.
    "@rspack/core": "1.4.3",

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Syntax Test Target Mismatch

The browser target for the pluginCheckSyntax test was unintentionally changed from 'ie 11' to 'android >= 4.4' when moving configuration to an external file. This significantly alters test behavior as IE 11 requires more aggressive syntax transpilation, potentially reducing the comprehensiveness of syntax checks for older browsers.

e2e/cases/source/source-include/rsbuild.config.ts#L6-L7

output: {
overrideBrowserslist: ['android >= 4.4'],

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@chenjiahan
Copy link
Member Author

This version breaks targets: ['ie 11'] and we will release a new patch after SWC fix it: swc-project/swc#10778

@chenjiahan chenjiahan merged commit ac39b81 into main Jul 4, 2025
11 checks passed
@chenjiahan chenjiahan deleted the update_rspack_1.4.3 branch July 4, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants