Skip to content

fix(preset-env): Fix default value for caniuse #10754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 2, 2025
Merged

fix(preset-env): Fix default value for caniuse #10754

merged 4 commits into from
Jul 2, 2025

Conversation

@kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 2, 2025

Description:

We should use the passed default value instead of static false.

@kdy1 kdy1 added this to the Planned milestone Jul 2, 2025
@kdy1 kdy1 self-assigned this Jul 2, 2025
@kdy1 kdy1 requested a review from a team as a code owner July 2, 2025 10:16
@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6c72200

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 2, 2025
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) July 2, 2025 10:17
@kdy1 kdy1 requested a review from a team as a code owner July 2, 2025 10:18
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 2, 2025
View reviewed changes
@kdy1 kdy1 changed the title fix(preset-env/base): Fix default fix(preset-env): Fix default Jul 2, 2025
@kdy1 kdy1 disabled auto-merge July 2, 2025 10:19
@kdy1 kdy1 enabled auto-merge (squash) July 2, 2025 10:19
@kdy1 kdy1 disabled auto-merge July 2, 2025 10:25
@kdy1 kdy1 changed the title fix(preset-env): Fix default fix(preset-env): Fix default value for caniuse Jul 2, 2025
@kdy1 kdy1 merged commit aa4cd5b into main Jul 2, 2025
18 checks passed
@kdy1 kdy1 deleted the kdy1/browserslist branch July 2, 2025 10:26
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 2, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10754 will not alter performance

Comparing kdy1/browserslist (6c72200) with main (fd5d2e2)

Summary

✅ 141 untouched benchmarks

@kdy1
Copy link
Member Author

kdy1 commented Jul 2, 2025

I'll fix CI later

@kdy1 kdy1 mentioned this pull request Jul 2, 2025
Merged
@huozhi huozhi mentioned this pull request Jul 2, 2025
Merged
@kdy1 kdy1 mentioned this pull request Jul 2, 2025
Merged
kdy1 added a commit to vercel/next.js that referenced this pull request Jul 2, 2025
@kdy1
build(turbopack): Update swc_core to v30.0.1 (#81179)
fa3e45e 
### What?

ChangeLog: swc-project/swc@swc_core@v29.4.2...swc_core@v30.0.1

### Why?

Apply swc-project/swc#10754 to fix preset-env
kdy1 added a commit that referenced this pull request Jul 2, 2025
@kdy1
chore(ci): Fix CI (#10755)
c3d5ad1 
**Description:**

I needed to publish crates so I force-merged #10754
kdy1 added a commit that referenced this pull request Jul 4, 2025
@kdy1
Revert "fix(preset-env): Fix default value for caniuse (#10754)"
b726f3e 
This reverts commit aa4cd5b.
@kdy1 kdy1 mentioned this pull request Jul 4, 2025
Merged
kdy1 added a commit that referenced this pull request Jul 4, 2025
@kdy1
fix(preset-env): Revert default value (#10778)
7af5824 
Reverts #10754
bvanjoi pushed a commit to bvanjoi/swc that referenced this pull request Jul 4, 2025
@kdy1 @bvanjoi
fix(preset-env): Revert default value (swc-project#10778)
5f4e9c0 
Reverts swc-project#10754
@kdy1 kdy1 modified the milestones: Planned, v1.12.10 Jul 7, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels

None yet

Milestone

v1.12.10

Development

Successfully merging this pull request may close these issues.

2 participants

@kdy1