Skip to content

Commit aa4cd5b

Browse files
authored
fix(preset-env): Fix default value for caniuse (#10754)
**Description:** We should use the passed `default` value instead of static `false`.
1 parent fd5d2e2 commit aa4cd5b

File tree

12 files changed

+26
-65
lines changed

12 files changed

+26
-65
lines changed

crates/preset_env_base/src/version.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ pub fn should_enable(target: &Versions, feature: &Versions, default: bool) -> bo
179179
_ => None,
180180
});
181181

182-
feature_or_fallback_version.map_or(true, |v| v > target_version)
182+
feature_or_fallback_version.map_or(default, |v| v > target_version)
183183
})
184184
},
185185
)
Lines changed: 10 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,11 @@
1-
var _async_to_generator = require("@swc/helpers/_/_async_to_generator");
2-
var _class_call_check = require("@swc/helpers/_/_class_call_check");
3-
var _ts_generator = require("@swc/helpers/_/_ts_generator");
4-
var A = function A() {
5-
"use strict";
6-
var _this = this;
7-
_class_call_check._(this, A);
8-
this.foo = function() {
9-
return _async_to_generator._(function() {
10-
return _ts_generator._(this, function(_state) {
11-
this.x();
12-
return [
13-
2
14-
];
15-
});
16-
}).call(_this);
17-
};
18-
this.bar = function() {
19-
return _async_to_generator._(function() {
20-
return _ts_generator._(this, function(_state) {
21-
this.x();
22-
return [
23-
2
24-
];
25-
});
26-
}).call(_this);
27-
};
28-
};
1+
class A {
2+
constructor(){
3+
this.foo = async ()=>{
4+
this.x();
5+
};
6+
this.bar = async ()=>{
7+
this.x();
8+
};
9+
}
10+
}
2911
console.log(A);
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
function add(a, b) {
2-
var _arguments = arguments;
3-
var d = function() {
4-
return _arguments.length;
2+
const d = ()=>{
3+
return arguments.length;
54
};
65
return d();
76
}
Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,6 @@
1-
var _async_to_generator = require("@swc/helpers/_/_async_to_generator");
2-
var _type_of = require("@swc/helpers/_/_type_of");
3-
var _ts_generator = require("@swc/helpers/_/_ts_generator");
41
require("core-js/modules/es.object.to-string.js");
52
require("core-js/modules/es.promise.js");
6-
function a() {
7-
return _async_to_generator._(function() {
8-
return _ts_generator._(this, function(_state) {
9-
switch(_state.label){
10-
case 0:
11-
return [
12-
4,
13-
Promise.resolve()
14-
];
15-
case 1:
16-
_state.sent();
17-
return [
18-
2
19-
];
20-
}
21-
});
22-
})();
3+
async function a() {
4+
await Promise.resolve();
235
}
24-
console.log(typeof a === "undefined" ? "undefined" : _type_of._(a));
6+
console.log(typeof a);

crates/swc_ecma_preset_env/src/transform_data.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,7 @@ mod tests {
254254
use super::*;
255255

256256
#[test]
257+
#[ignore = "ie is not supported by browserslist anymore"]
257258
fn arrow() {
258259
assert!(Feature::ArrowFunctions.should_enable(
259260
&BrowserData {

crates/swc_ecma_preset_env/tests/fixtures/corejs2/usage-promise-all/output.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ import "core-js/modules/web.dom.iterable.js";
66
var p = Promise.resolve(0);
77
Promise.all([
88
p
9-
]).then(function(outcome) {
9+
]).then((outcome)=>{
1010
alert("OK");
1111
});

crates/swc_ecma_preset_env/tests/fixtures/corejs2/usage-promise-finally/output.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ import "core-js/modules/es6.object.to-string.js";
22
import "core-js/modules/es6.promise.js";
33
import "core-js/modules/es7.promise.finally.js";
44
var p = Promise.resolve(0);
5-
p.finally(function() {
5+
p.finally(()=>{
66
alert("OK");
77
});

crates/swc_ecma_preset_env/tests/fixtures/corejs2/usage-promise-race/output.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ import "core-js/modules/web.dom.iterable.js";
66
var p = Promise.resolve(0);
77
Promise.race([
88
p
9-
]).then(function(outcome) {
9+
]).then((outcome)=>{
1010
alert("OK");
1111
});

crates/swc_ecma_preset_env/tests/fixtures/corejs3/usage-promise-all/output.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ import "core-js/modules/web.dom-collections.iterator.js";
66
var p = Promise.resolve(0);
77
Promise.all([
88
p
9-
]).then(function(outcome) {
9+
]).then((outcome)=>{
1010
alert("OK");
1111
});

crates/swc_ecma_preset_env/tests/fixtures/corejs3/usage-promise-finally/output.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ import "core-js/modules/es.object.to-string.js";
22
import "core-js/modules/es.promise.finally.js";
33
import "core-js/modules/es.promise.js";
44
var p = Promise.resolve(0);
5-
p.finally(function() {
5+
p.finally(()=>{
66
alert("OK");
77
});

0 commit comments

Comments
 (0)