This repository was archived by the owner on Apr 18, 2025. It is now read-only.
Handle precompile call failure call.is_success == false due to "Invalid Inputs" and "Insufficient Gas"
#811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
* enforce gas_cost for ec_add * enforce gas_cost for ec_mul * enforce gas_cost for ec_pairing * fix: test case generation random G2 coeffs * chore: refactor unnecessary cell being returned * enforce gas_cost for modexp * remove tests for gadget that wont be used * tests: invalid cases for ecpairing * fix: input cells (pairing) for RLC --------- Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com>
4 tasks
roynalnaruto
changed the title
call.is_success == false due to "Invalid Inputs" and "Insufficient Gas"
lispc
reviewed
Aug 26, 2023
|
generally looks good now. complex codes anyway. need some tests after or before merging:
TODO later:
|
Author
10 tasks
lispc
force-pushed
the
feat/invalid-inputs-precompile
branch
from
5c02a61 to
4223a54
Compare
* add oog test for ec add * add precompile oog gadget * add oog precompile in bus-mapping * fix compile error * fix * fix copy input bytes even precompile calls oog * fix constraint errors * add oog test for ec_mul & ec_pairing * add identity oog * fix * add oog in modexp --------- Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com>
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EccCircuithandles both valid and invalid inputs toEcAddEcMulEcPairingEcAddEcMulEcPairingModexpupgrade "misc-precompiled-circuits" and handle modexp invalid len in bus-mapping #830EcrecoverandIdentitydo not have a failure case for invalid inputsEcAddEcMulEcPairingModexpEcrecoverIdentitySHA2-256,RIPEMD-160,BLAKE2F) still use thePrecompileFaileddummy gadgetIssue Link
Closes #799
Type of change