Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

upgrade "misc-precompiled-circuits" and handle modexp invalid len in bus-mapping #830

Merged
lispc merged 13 commits into from
Aug 29, 2023
Merged

upgrade "misc-precompiled-circuits" and handle modexp invalid len in bus-mapping #830

lispc merged 13 commits into from
Aug 29, 2023

Conversation

@lispc
Copy link

@lispc lispc commented Aug 27, 2023 •
edited
Loading

  1. (done)upgrade the "misc-precompiled-circuit" dependency
  2. fix ci. @DreamWuGit up to you.
  3. update some hardcoded parameter like MODEXPCONFIG_EACH_CHIP_ROWS
  4. fix modexp invalid inputs (oog and length large than 32)

@lispc lispc changed the title tag modexp circuit fix modexp Aug 27, 2023
@lispc lispc mentioned this pull request Aug 28, 2023
Merged
20 tasks
@lispc lispc requested a review from noel2004 August 28, 2023 08:20
@lispc lispc changed the title fix modexp upgrade "misc-precompiled-circuits" and handle modexp invalid len in bus-mapping Aug 29, 2023
@lispc lispc merged commit 517127f into develop Aug 29, 2023
@lispc lispc deleted the chore/upgrade-modexp branch August 29, 2023 05:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noel2004 noel2004 Awaiting requested review from noel2004

Assignees

No one assigned

Labels

crate-zkevm-circuits

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lispc @DreamWuGit @kunxian-xia