This repository was archived by the owner on Apr 18, 2025. It is now read-only.
Feat: enforce gas_cost for precompiles called with invalid inputs #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roynalnaruto
approved these changes
Aug 25, 2023
lispc
added a commit
that referenced
this pull request
Aug 28, 2023
…alid Inputs" and "Insufficient Gas" (#811) * wip: preliminary work (EcAdd) * wip: refactoring ecc circuit and ecaddop * wip: prelim work for EcMul * wip: ecmul decompose and more tests * wip: some more changes in EcAdd and EcMul gadgets (evm cir) * fix: refactor is_zero to avoid enforce < p * chore: add back traces * chore: update cargo lock * chore: refactor AND to AND many * wip: ecpairing in ecc ciruit * fix: ecpairing ecc circuit debugged * feat: invalid len(input) handling in ecpairing gadget * assignment to ecpairing cells, tests OK * is_valid todo complete * minor refactor * add invalid test for ec add * chore: clippy fix * fix: precompile failed (ecXX) through individual gadgets * Feat: enforce gas_cost for precompiles called with invalid inputs (#827) * enforce gas_cost for ec_add * enforce gas_cost for ec_mul * enforce gas_cost for ec_pairing * fix: test case generation random G2 coeffs * chore: refactor unnecessary cell being returned * enforce gas_cost for modexp * remove tests for gadget that wont be used * tests: invalid cases for ecpairing * fix: input cells (pairing) for RLC --------- Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com> * gas costs for ecrecover and identity * chore: fmt fix * upgrade halo2-lib * variadic size tests with valid/invalid inputs --------- Co-authored-by: kunxian xia <xiakunxian130@gmail.com> Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Meant to be a part of #811.
Issue Link
Type of change