This repository was archived by the owner on Apr 18, 2025. It is now read-only.
forked from privacy-ethereum/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 389
Super Circuit Invalid Precompile Inputs Integration Tests (OOG, EC Fp Overflow, EC Not on Curve) #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roynalnaruto do you think it is a good idea to use several super circuit circuits? The benefit is when some precompiles fails, we can know which fails from ci quickly. The drawback is it takes longer CI time. I would slightly prefer to put multi txs into same super circuit. So CI will not be slower. Usually it will not fail. Even if it fails, it is not difficult to debug which one is the problem. |
|
@darth-cy some clippy and fmt error |
|
I marked this as ready for review only to trigger the CI. |
4 tasks
|
mark ready to get ci up. |
…-invalid-precompile
|
@z2trillion a331143 should be reverted as the "tx-circuit" related CI errors have already been fixed in #935. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add additional precompile integration test on
super_circuitfor OOG, EC pts coordinatesFpoverflow and EC pts not on curve. Refactorsuper_circuitprecompile testing block trace generation. Follow up QA on #811.Issue Link
Closes #834
Type of change