Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Conversation

@darth-cy
Copy link

@darth-cy darth-cy commented Aug 30, 2023

Description

Add additional precompile integration test on super_circuit for OOG, EC pts coordinates Fp overflow and EC pts not on curve. Refactor super_circuit precompile testing block trace generation. Follow up QA on #811.

Issue Link

Closes #834

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@darth-cy darth-cy requested a review from roynalnaruto August 31, 2023 22:08
@lispc lispc marked this pull request as ready for review September 2, 2023 02:31
@lispc lispc marked this pull request as draft September 2, 2023 02:35
@lispc
Copy link

lispc commented Sep 2, 2023

@roynalnaruto do you think it is a good idea to use several super circuit circuits? The benefit is when some precompiles fails, we can know which fails from ci quickly. The drawback is it takes longer CI time.

I would slightly prefer to put multi txs into same super circuit. So CI will not be slower. Usually it will not fail. Even if it fails, it is not difficult to debug which one is the problem.

@lispc
Copy link

lispc commented Sep 2, 2023

@darth-cy some clippy and fmt error

@z2trillion z2trillion marked this pull request as ready for review September 12, 2023 01:19
@z2trillion
Copy link

I marked this as ready for review only to trigger the CI.

@kunxian-xia kunxian-xia marked this pull request as ready for review September 12, 2023 08:46
@kunxian-xia kunxian-xia marked this pull request as draft September 12, 2023 11:36
@kunxian-xia
Copy link

mark ready to get ci up.

@lispc lispc marked this pull request as ready for review September 12, 2023 11:40
@kunxian-xia
Copy link

kunxian-xia commented Sep 13, 2023

@z2trillion a331143 should be reverted as the "tx-circuit" related CI errors have already been fixed in #935.

@lispc lispc merged commit 7f48ba8 into develop Sep 13, 2023
@lispc lispc deleted the test/super-circuit-invalid-precompile branch September 13, 2023 02:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: begin_tx precompile out of gas error

6 participants