Repository navigation
Remove experimental --env-set option - #161831
Merged
Merged
Conversation
Collaborator
|
cc @rust-lang/rust-analyzer |
rustbot
added
S-waiting-on-review
GuillaumeGomez
approved these changes
Aug 26, 2026
nnethercote
reviewed
Aug 30, 2026
Because it's enabled by -Zunstable-options. :) |
nnethercote
approved these changes
Aug 30, 2026
Contributor
There was a problem hiding this comment.
If it's good enough for @GuillaumeGomez it's good enough for me.
| So if you first passed: | ||
|
|
||
| ```bash | ||
| --env-set A=B --env X=12 |
Contributor
There was a problem hiding this comment.
This --env was out of date.
Contributor
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
Rollup merge of #161831 - Urgau:rm-env-set, r=nnethercote Remove experimental `--env-set` option This PR removes the experimental/unstable `--env-set` option. The primary motivation for the feature meson/ninja [consider it](#161609 (comment)) insufficient and a failure. They are even [planning](#161609 (comment)) to use a wrapper anyway, entirely removing the need for it. I looked at GitHub search and apart from Buck2 who [seemed to be using it](#161609 (comment)), I didn't find a significant user.
1 of 3 tasks
asukaminato0721
pushed a commit
to asukaminato0721/rust-analyzer
that referenced
this pull request
Sep 2, 2026
Rollup of 3 pull requests Successful merges: - rust-lang/rust#161603 (Add llubi to llvm-tools) - rust-lang/rust#161831 (Remove experimental `--env-set` option) - rust-lang/rust#161721 (Add f16 summary provider for PDB debug info)
mikeslade
added a commit
to mikeslade/rust-lints
that referenced
this pull request
Sep 27, 2026
…iver for the removed --env-set (#11) nix flake update moved only crane; #10 already carried nixpkgs and rust-overlay to today's snapshot, so the toolchain stays nightly-2026-09-27. cargo update moves 35 packages, among them dylint_linting 6.0.2 -> 6.1.0, and the flake's dylint tools follow. rust-lang/rust#161831 removed the unstable --env-set flag on 2026-08-31. dylint >= 6.0.3 passes it on every lint run, so its driver fails on any newer nightly with "Unrecognized option: 'env-set'" (trailofbits/dylint#2078, still open). The flake now patches the driver source to stop passing the flag, restoring the 6.0.2 behaviour, with --replace-fail so the upstream fix shows up here as a build failure. Also fixes one clippy redundant_closure so clippy is clean.
dmandreev
added a commit
to issuerd/issuerd
that referenced
this pull request
Sep 30, 2026
Four syntax-only, deny-by-default lints over a pre-expansion early pass (no name resolution, no clippy_utils dependency), enforcing the AGENTS.md "Logging Conventions" at compile time: - tracing_error_debug: error/err fields must use the % (Display) sigil, not ? (Debug), at any level. - secret_field_in_log: no secret-named fields (password/token/code/ cookie/...) in event macros or #[instrument(fields(...))]; metadata suffixes (_hash/_len/_count/_type/_id) and the OAuth-vocabulary token_*/code_*/authorization_* compounds are exempt. - session_id_in_log: session_id/sid fields only at DEBUG/TRACE, never in span fields. - instrument_skip_sensitive: sensitive #[instrument] parameters (state/headers/body/params/query/IPs, *_token/*_secret/*_password/ *_code/*_assertion/*_key) must be in skip(...)/skip_all. The crate is a detached workspace ([workspace] table) pinned to nightly-2026-08-20: dylint's driver passes the unstable --env-set flag (trailofbits/dylint#2010) which rustc removed in rust-lang/rust#161831 (merged 2026-08-31), so the pin must predate the removal (trailofbits/dylint#2078). Ui tests via dylint_testing/compiletest cover positive and negative cases for all four lints (cargo test in the crate).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the experimental/unstable
--env-setoption.The primary motivation for the feature meson/ninja consider it insufficient and a failure. They are even planning to use a wrapper anyway, entirely removing the need for it.
I looked at GitHub search and apart from Buck2 who seemed to be using it, I didn't find a significant user.
Close-ish #118372
cc @GuillaumeGomez @bonzini
r? @nnethercote