Skip to content

Rollup of 3 pull requests - #162035

Merged
rust-bors[bot] merged 6 commits into
rust-lang:mainfrom
jhpratt:rollup-713BXvV
Aug 31, 2026
Merged

rust-bors[bot] merged 6 commits into
rust-lang:mainfrom
jhpratt:rollup-713BXvV

Conversation

@jhpratt

@jhpratt jhpratt commented Aug 31, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

Walnut356 and others added 6 commits August 25, 2026 01:11
…crum

Add llubi to llvm-tools

llubi is a tool that should be very useful when investigating problems with LLVM, because like Miri it is supposed to tell you if executing some LLVM IR encounters UB (with usual caveats).

(and also clean up comments on adjacent tools)
Remove experimental `--env-set` option

This PR removes the experimental/unstable `--env-set` option.

The primary motivation for the feature meson/ninja [consider it](rust-lang#161609 (comment)) insufficient and a failure. They are even [planning](rust-lang#161609 (comment)) to use a wrapper anyway, entirely removing the need for it.

I looked at GitHub search and apart from Buck2 who [seemed to be using it](rust-lang#161609 (comment)), I didn't find a significant user.
Add f16 summary provider for PDB debug info

`f16`  doesn't have a proper node in the PDB format, so it ends up output as a struct with a `bits` field. This change adds a summary provider that casts to a clang `half` type and retrieves the summary from that. Neither of these operations can fail since `half` is built-in as far as clang/lldb are concerned.

Fixes `tests\debuginfo\borrowed-basic.rs` and `tests\debuginfo\reference-debuginfo.rs`, which [currently fail on `windows-msvc`](rust-lang#161657)
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Aug 31, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. labels Aug 31, 2026
@jhpratt

jhpratt commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

@bors r+ p=5

@rust-bors

rust-bors Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bf66970 has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2026
@rust-bors

This comment has been minimized.

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job aarch64-gnu-llvm-21-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
test /checkout/obj/build/aarch64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0060 (line 1283) - compile fail ... ok
test /checkout/obj/build/aarch64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0062 (line 1343) - compile fail ... ok
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

Session terminated, killing shell...::group::Clock drift check
  local time: Mon Aug 31 01:48:58 UTC 2026
  network time: test /checkout/obj/build/aarch64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0063 (line 1375) - compile fail ... ok
test /checkout/obj/build/aarch64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0060 (line 1296) ... ok
test /checkout/obj/build/aarch64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0061 (line 1329) ... ok
test /checkout/obj/build/aarch64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0067 (line 1404) - compile fail ... ok

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 31, 2026
@rust-bors

rust-bors Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 14m 44s
Pushing 5321a4f to main...

@rust-bors
rust-bors Bot merged commit 5321a4f into rust-lang:main Aug 31, 2026
6 of 14 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Aug 31, 2026
@jhpratt
jhpratt deleted the rollup-713BXvV branch August 31, 2026 04:42
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4b7e3a7 (parent) -> 5321a4f (this PR)

Test differences

Show 15 test diffs

Stage 1

  • [ui (polonius)] tests/ui/env-macro/env-env-overload.rs: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/env-macro/env-env.rs: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/env-macro/simple.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/feature-gates/env-flag.rs: pass -> [missing] (J0)
  • [ui] tests/ui/env-macro/env-env-overload.rs: pass -> [missing] (J2)
  • [ui] tests/ui/env-macro/env-env.rs: pass -> [missing] (J2)
  • [ui] tests/ui/env-macro/simple.rs: [missing] -> pass (J2)
  • [ui] tests/ui/feature-gates/env-flag.rs: pass -> [missing] (J2)

Stage 2

  • [ui] tests/ui/env-macro/env-env-overload.rs: pass -> [missing] (J1)
  • [ui] tests/ui/env-macro/env-env.rs: pass -> [missing] (J1)
  • [ui] tests/ui/env-macro/simple.rs: [missing] -> pass (J1)
  • [ui] tests/ui/feature-gates/env-flag.rs: pass -> [missing] (J1)
  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) (J3)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5321a4f40c957cf3587c055e77461febc2ebc865 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-stdlib-semver-check: 9m 24s -> 29m 21s (+212.2%)
  2. x86_64-gnu-gcc-core-tests: 9m 54s -> 29m 41s (+199.8%)
  3. dist-aarch64-apple: 1h 30m -> 2h 33m (+70.2%)
  4. test-various: 1h 37m -> 2h 46m (+69.9%)
  5. pr-check-1: 33m 26s -> 51m 5s (+52.8%)
  6. arm-android: 1h 22m -> 2h 5m (+51.9%)
  7. dist-riscv64-linux-musl: 59m 17s -> 1h 29m (+51.7%)
  8. x86_64-gnu-next-trait-solver-polonius: 54m 11s -> 1h 17m (+43.8%)
  9. x86_64-gnu-llvm-21-1: 42m 8s -> 59m 46s (+41.9%)
  10. x86_64-gnu-llvm-22-1: 59m 11s -> 1h 20m (+35.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (5321a4f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.2%, secondary 7.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
7.1% [7.1%, 7.1%] 1
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Cycles

Results (primary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.5% [-2.5%, -2.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.2% [-2.5%, 2.1%] 2

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.0%] 4
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [0.0%, 0.0%] 4

Bootstrap: 476.296s -> 477.635s (0.28%)
Artifact size: 402.80 MiB -> 402.71 MiB (-0.02%)

@rust-bors

rust-bors Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#161603 Add llubi to llvm-tools 8ca547f39a36189d40bed0e8176844b1251b29b5
(link)
#161831 Remove experimental --env-set option 4bdd45ca365178c74a0eb9f2b6b3bf227e3d7447
(link)
#161721 Add f16 summary provider for PDB debug info 3a4a7d12df25ee536fa0f400cf2552ce16b56ea0
(link)

parent commit: 4b7e3a76d8

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants