Repository navigation
Add f16 summary provider for PDB debug info - #161721
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@bors r+ rollup Is half builtin on all supported versions of clang/lldb from our perspective? |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
Author
|
Yup, iirc it was added like 14 years ago |
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
Rollup merge of #161721 - Walnut356:f16_msvc, r=Mark-Simulacrum Add f16 summary provider for PDB debug info `f16` doesn't have a proper node in the PDB format, so it ends up output as a struct with a `bits` field. This change adds a summary provider that casts to a clang `half` type and retrieves the summary from that. Neither of these operations can fail since `half` is built-in as far as clang/lldb are concerned. Fixes `tests\debuginfo\borrowed-basic.rs` and `tests\debuginfo\reference-debuginfo.rs`, which [currently fail on `windows-msvc`](#161657)
asukaminato0721
pushed a commit
to asukaminato0721/rust-analyzer
that referenced
this pull request
Sep 2, 2026
Rollup of 3 pull requests Successful merges: - rust-lang/rust#161603 (Add llubi to llvm-tools) - rust-lang/rust#161831 (Remove experimental `--env-set` option) - rust-lang/rust#161721 (Add f16 summary provider for PDB debug info)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f16doesn't have a proper node in the PDB format, so it ends up output as a struct with abitsfield. This change adds a summary provider that casts to a clanghalftype and retrieves the summary from that. Neither of these operations can fail sincehalfis built-in as far as clang/lldb are concerned.Fixes
tests\debuginfo\borrowed-basic.rsandtests\debuginfo\reference-debuginfo.rs, which currently fail onwindows-msvc