Repository navigation
chore: update crane, cargo deps, and dylint to 6.1.0, patching its driver for the removed --env-set - #11
Merged
Conversation
…iver for the removed --env-set nix flake update moved only crane; #10 already carried nixpkgs and rust-overlay to today's snapshot, so the toolchain stays nightly-2026-09-27. cargo update moves 35 packages, among them dylint_linting 6.0.2 -> 6.1.0, and the flake's dylint tools follow. rust-lang/rust#161831 removed the unstable --env-set flag on 2026-08-31. dylint >= 6.0.3 passes it on every lint run, so its driver fails on any newer nightly with "Unrecognized option: 'env-set'" (trailofbits/dylint#2078, still open). The flake now patches the driver source to stop passing the flag, restoring the 6.0.2 behaviour, with --replace-fail so the upstream fix shows up here as a build failure. Also fixes one clippy redundant_closure so clippy is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine update of the flake inputs, the rolling nightly, and the Cargo dependencies, plus the one fix the dependency bump forces.
What changed
nix flake update: onlycranemoved (2026-08-03 → 2026-09-18). fix(lib): build on nightly-2026-09-27, and find a glob nested in a use list #10 already tooknixpkgsandrust-overlayto today's snapshot, so the resolved toolchain staysnightly-2026-09-27.cargo update: 35 packages, includingdylint_linting6.0.2 → 6.1.0.Cargo.tomland the flake'sdylintToolsVersionfollow it, socargo-dylint,dylint-linkand the runtime driver are all 6.1.0.--env-setoption rust-lang/rust#161831 (merged 2026-08-31) removed the unstable--env-setflag; dylint ≥ 6.0.3 passes it on every lint run to carry a state hash into rustc's incremental cache key, so on any newer nightly the driver dies withUnrecognized option: 'env-set'before linting anything. This is--env-sethas been removed from rustc, breakingDYLINT_UNTRACKED_STATEtrailofbits/dylint#2078, open and unfixed on master as of today. The patch stops passing the flag, which restores the 6.0.2 behaviour (a stale incremental cache is the caller's problem; the fixture checker already lints from a cold target dir). It is applied with--replace-fail, so the upstream fix will surface here as a build failure, which is the cue to drop it.redundant_closureinis_fallible_conversion_name's call site, so clippy is clean on this nightly.Pinning dylint at 6.0.2 was the alternative; rejected because every later dylint release carries the flag, so the pin would have blocked all future dylint updates until upstream ships a replacement mechanism.
How verified
nix flake checknix develop -c cargo testnix develop -c cargo fmt --checknix develop -c cargo clippy --all-targetsnix develop -c scripts/check-blocking-in-async-fixture.sh(driver cache cleared first, so the driver was rebuilt from the patched source)cargo dylint --all -- --workspace(README command)Unrecognized option: 'env-set'on the driver'srustc -vVprobe