Skip tidy in PR CI jobs not dedicated to running tidy#152845
Open
jieyouxu wants to merge 1 commit intorust-lang:mainfrom
Open
Skip tidy in PR CI jobs not dedicated to running tidy#152845jieyouxu wants to merge 1 commit intorust-lang:mainfrom
tidy in PR CI jobs not dedicated to running tidy#152845jieyouxu wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-CI
This comment has been minimized.
This comment has been minimized.
jieyouxu
force-pushed
the
split-tidy-from-pr-test-jobs
branch
from
e744645 to
8a71bea
Compare
jieyouxu
commented
Feb 19, 2026
Member
Author
|
Hm, need to double-check when |
jieyouxu
force-pushed
the
split-tidy-from-pr-test-jobs
branch
3 times, most recently
from
0454a0e to
61cb25a
Compare
This comment has been minimized.
This comment has been minimized.
This is both: 1. Redundant, since PR CI has a dedicated `tidy` job 2. A contributor roadblock, because tidy failures block further failures from being revealed. We *only* skip tidy in PR CI and not in Merge CI because tidy in Merge CI will early-cancel *anyway*.
jieyouxu
force-pushed
the
split-tidy-from-pr-test-jobs
branch
from
61cb25a to
498f111
Compare
Member
Author
|
Checked PR CI run (https://github.com/rust-lang/rust/actions/runs/22259809434):
|
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @marcoieni rustbot has assigned @marcoieni. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 24, 2026
…obs, r=marcoieni Skip `tidy` in PR CI jobs not dedicated to running `tidy` This is both: 1. Redundant, since PR CI has a dedicated `tidy` job which runs in parallel and doesn't early-cancel other PR CI jobs 2. A contributor roadblock, because tidy failures in one test jobs block further failures from other test jobs being revealed. (2) defeats the parallel-but-not-early-cancelling reason of the separate `tidy` job in the first place. This PR skips tidy from being run in PR CI jobs that are not dedicated to running `tidy` (i.e. the non-`tidy` CI jobs). Fixes rust-lang#148932.
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 24, 2026
…uwer Rollup of 15 pull requests Successful merges: - #152176 (Neon fast path for str::contains) - #152657 (std: move `exit` out of PAL) - #152841 (Streamline `QueryVTableUnerased` into `GetQueryVTable`) - #152845 (Skip `tidy` in PR CI jobs not dedicated to running `tidy`) - #152897 (Add optional json logging) - #153009 (Remove `rustc_feedable_queries` and `define_feedable` macros.) - #151558 (Port diagnostic attributes) - #152492 (mGCA: Enforce WF element types for array valtrees) - #152888 (Fix async drop glue MIR bug) - #152988 (Port `#[register_tool]` to the new attribute system) - #153018 (`unused_must_use` lint improvements) - #153023 (Update books) - #153033 (Clarify how "ensure" queries check whether they can skip execution) - #153043 (fix error on missing value for -C flags) - #153045 (rustc-dev-guide subtree update) Failed merges: - #153032 (Fix attribute parser and kind names.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is both:
tidyjob which runs in parallel and doesn't early-cancel other PR CI jobs(2) defeats the parallel-but-not-early-cancelling reason of the separate
tidyjob in the first place.This PR skips tidy from being run in PR CI jobs that are not dedicated to running
tidy(i.e. the non-tidyCI jobs).Fixes #148932.