Skip to content

Comments

Port #[register_tool] to the new attribute system#152988

Open
JonathanBrouwer wants to merge 2 commits intorust-lang:mainfrom
JonathanBrouwer:register-tool
Open

Port #[register_tool] to the new attribute system#152988
JonathanBrouwer wants to merge 2 commits intorust-lang:mainfrom
JonathanBrouwer:register-tool

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Feb 22, 2026

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 22, 2026
@JonathanBrouwer JonathanBrouwer marked this pull request as ready for review February 22, 2026 20:25
@rustbot
Copy link
Collaborator

rustbot commented Feb 22, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 22, 2026
@rust-log-analyzer

This comment has been minimized.

@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 23, 2026

📌 Commit 436315d has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 23, 2026
…donszelmann

Port `#[register_tool]` to the new attribute system

For rust-lang#131229 (comment)
Rebase of rust-lang#146702

r? @jdonszelmann
rust-bors bot pushed a commit that referenced this pull request Feb 23, 2026
Rollup of 6 pull requests

Successful merges:

 - #153007 (`rust-analyzer` subtree update)
 - #152768 (Enable autodiff in ci for all major os)
 - #152003 (Reflection TypeId::trait_info_of)
 - #152988 (Port `#[register_tool]` to the new attribute system)
 - #152989 (Port `#[rustc_inherit_overflow_checks]` to the new attribute parsers)
 - #152991 (fix interpreter tracing output)
rust-bors bot pushed a commit that referenced this pull request Feb 23, 2026
…uwer

Rollup of 14 pull requests

Successful merges:

 - #153007 (`rust-analyzer` subtree update)
 - #152670 (Simplify ThinLTO handling)
 - #152768 (Enable autodiff in ci for all major os)
 - #152908 (Enable rust.remap-debuginfo in the dist profile)
 - #152999 (Check importing `crate`/`$crate`/`super` after handling `self`)
 - #152003 (Reflection TypeId::trait_info_of)
 - #152976 (Revert relative paths for std links in rustc-docs)
 - #152985 (Port `#[feature]` to the new attribute system)
 - #152989 (Port `#[rustc_inherit_overflow_checks]` to the new attribute parsers)
 - #152991 (fix interpreter tracing output)
 - #153004 (Superficial tweaks to the query modifier docs in `rustc_middle::query::modifiers`)
 - #153008 (bootstrap.compiler.toml: update name of primary branch)
 - #153016 (Migration of `LintDiagnostic` - part 2)
 - #153020 (rustdoc: Improve sentence for documented empty impl blocks)

Failed merges:

 - #152988 (Port `#[register_tool]` to the new attribute system)
rust-bors bot pushed a commit that referenced this pull request Feb 24, 2026
…uwer

Rollup of 14 pull requests

Successful merges:

 - #153007 (`rust-analyzer` subtree update)
 - #152670 (Simplify ThinLTO handling)
 - #152768 (Enable autodiff in ci for all major os)
 - #152908 (Enable rust.remap-debuginfo in the dist profile)
 - #152999 (Check importing `crate`/`$crate`/`super` after handling `self`)
 - #152003 (Reflection TypeId::trait_info_of)
 - #152976 (Revert relative paths for std links in rustc-docs)
 - #152985 (Port `#[feature]` to the new attribute system)
 - #152989 (Port `#[rustc_inherit_overflow_checks]` to the new attribute parsers)
 - #152991 (fix interpreter tracing output)
 - #153004 (Superficial tweaks to the query modifier docs in `rustc_middle::query::modifiers`)
 - #153008 (bootstrap.compiler.toml: update name of primary branch)
 - #153016 (Migration of `LintDiagnostic` - part 2)
 - #153020 (rustdoc: Improve sentence for documented empty impl blocks)

Failed merges:

 - #152988 (Port `#[register_tool]` to the new attribute system)
@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2026
@rust-bors

This comment has been minimized.

JonathanBrouwer and others added 2 commits February 24, 2026 09:34
Co-authored-by: Jana Dönszelmann <jana@donsz.nl>
Co-authored-by: Jana Dönszelmann <jana@donsz.nl>
@JonathanBrouwer
Copy link
Contributor Author

@bors r=jdonszelmann

@rustbot
Copy link
Collaborator

rustbot commented Feb 24, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 24, 2026

📌 Commit 07bf6ae has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 24, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 24, 2026
…donszelmann

Port `#[register_tool]` to the new attribute system

For rust-lang#131229 (comment)
Rebase of rust-lang#146702

r? @jdonszelmann
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 24, 2026
…donszelmann

Port `#[register_tool]` to the new attribute system

For rust-lang#131229 (comment)
Rebase of rust-lang#146702

r? @jdonszelmann
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants