Conversation
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
|
r? @nnethercote rustbot has assigned @nnethercote. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
(Note, I accidentally added two copies of the same file I was using to test this issue. Please let me know where I'm supposed to put it) |
This comment has been minimized.
This comment has been minimized.
Either seems fine, but one of them is missing a trailing newline which is causing the tidy failure. Beyond that I'm not a MIR expert, let's try: r? @oli-obk |
|
|
|
@oli-obk could you check again? I think I put the test in the right place (note that I should probably squash the commits) |
This comment has been minimized.
This comment has been minimized.
ValorZard
force-pushed
the
async-drop-fix
branch
from
ca46596 to
f2d4173
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Yep, this lgtm now. Please squash the commits |
ValorZard
force-pushed
the
async-drop-fix
branch
from
0be3acd to
ce93a53
Compare
|
@oli-obk commits squashed, ready for merge |
|
Thanks! @bors r+ rollup |
rust-bors
bot
added
S-waiting-on-bors
Fix async drop glue MIR bug Attempted to fix rust-lang#142560 Relevant Zulip (where I talk a lot more about what I did): [#wg-async > is there a way I can help with Async Drop?](https://rust-lang.zulipchat.com/#narrow/channel/187312-wg-async/topic/is.20there.20a.20way.20I.20can.20help.20with.20Async.20Drop.3F/with/572847292)
…uwer Rollup of 15 pull requests Successful merges: - #152176 (Neon fast path for str::contains) - #152657 (std: move `exit` out of PAL) - #152841 (Streamline `QueryVTableUnerased` into `GetQueryVTable`) - #152845 (Skip `tidy` in PR CI jobs not dedicated to running `tidy`) - #152897 (Add optional json logging) - #153009 (Remove `rustc_feedable_queries` and `define_feedable` macros.) - #151558 (Port diagnostic attributes) - #152492 (mGCA: Enforce WF element types for array valtrees) - #152888 (Fix async drop glue MIR bug) - #152988 (Port `#[register_tool]` to the new attribute system) - #153018 (`unused_must_use` lint improvements) - #153023 (Update books) - #153033 (Clarify how "ensure" queries check whether they can skip execution) - #153043 (fix error on missing value for -C flags) - #153045 (rustc-dev-guide subtree update) Failed merges: - #153032 (Fix attribute parser and kind names.)
5 participants
Attempted to fix #142560
Relevant Zulip (where I talk a lot more about what I did): #wg-async > is there a way I can help with Async Drop?