Neon fast path for str::contains#152176
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 24, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
Member
|
I can't vouch for correctness. @rustbot reroll |
Member
How do you know? Did we run benchmarks (can you provide the results)? |
Mark-Simulacrum
added
S-waiting-on-author
Contributor
Author
|
I didn't see any benchmarks for this in tree but I did write a few quick ones, something such as: let data = "Lorem ipsum dolor sit amet";
c.bench_function("amet", |b| b.iter(|| black_box("amet".is_contained_in(&data))));Nightly: [41.489 ns 41.512 ns 41.534 ns] |
davidtwco
added
S-waiting-on-review
Mark-Simulacrum
added
the
relnotes-perf
Member
|
Seems like a reasonable result. Thanks for checking! @bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 24, 2026
…=Mark-Simulacrum Neon fast path for str::contains Using the SIMD friendly version of the function also gives a decent speed up with Neon.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 24, 2026
…=Mark-Simulacrum Neon fast path for str::contains Using the SIMD friendly version of the function also gives a decent speed up with Neon.
This was referenced Feb 24, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 24, 2026
…uwer Rollup of 15 pull requests Successful merges: - #152176 (Neon fast path for str::contains) - #152657 (std: move `exit` out of PAL) - #152841 (Streamline `QueryVTableUnerased` into `GetQueryVTable`) - #152845 (Skip `tidy` in PR CI jobs not dedicated to running `tidy`) - #152897 (Add optional json logging) - #153009 (Remove `rustc_feedable_queries` and `define_feedable` macros.) - #151558 (Port diagnostic attributes) - #152492 (mGCA: Enforce WF element types for array valtrees) - #152888 (Fix async drop glue MIR bug) - #152988 (Port `#[register_tool]` to the new attribute system) - #153018 (`unused_must_use` lint improvements) - #153023 (Update books) - #153033 (Clarify how "ensure" queries check whether they can skip execution) - #153043 (fix error on missing value for -C flags) - #153045 (rustc-dev-guide subtree update) Failed merges: - #153032 (Fix attribute parser and kind names.)
rust-timer
added a commit
that referenced
this pull request
Feb 24, 2026
Rollup merge of #152176 - JamieCunliffe:neon-str-contains, r=Mark-Simulacrum Neon fast path for str::contains Using the SIMD friendly version of the function also gives a decent speed up with Neon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the SIMD friendly version of the function also gives a decent speed up with Neon.