Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uefi: process: Add args support #129838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ayush1325
Copy link
Contributor

r​? joboet

@rustbot
Copy link
Collaborator

rustbot commented Aug 31, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 31, 2024
@Ayush1325
Copy link
Contributor Author

r? @joboet

@rustbot
Copy link
Collaborator

rustbot commented Aug 31, 2024

Could not assign reviewer from: joboet.
User(s) joboet are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@Ayush1325
Copy link
Contributor Author

Well, any new reviewer might want to look at: #123196 for more context about uefi process.

@Ayush1325 Ayush1325 force-pushed the uefi-process-args branch 2 times, most recently from 955ec4c to ab840e0 Compare September 1, 2024 20:37
@Ayush1325
Copy link
Contributor Author

ping @Amanieu

library/std/src/sys/pal/uefi/process.rs Outdated Show resolved Hide resolved
library/std/src/sys/pal/uefi/process.rs Outdated Show resolved Hide resolved
library/std/src/sys/pal/uefi/process.rs Outdated Show resolved Hide resolved
library/std/src/sys/pal/uefi/process.rs Outdated Show resolved Hide resolved
- Wrap all args with quotes.
- Escape ^ and " inside quotes using ^.

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants