core: move intrinsics.rs into intrinsics folder

[RalfJung]

This makes the rustbot notification we have set up for this folder in triagebot.toml actually work. Also IMO it makes more sense to have it all in one folder.

[rustbot]

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri

[ChrisDenton]

This feels like a limitation of triagebot that should ideally be addressed.

[lqd]

Wouldn't a [mentions."library/core/src/intrinsics.rs"] work here?

[RalfJung]

Yeah, but IMO it makes more sense to have all the intrinsics in one folder.

[workingjubilee]

oh boy, is it time for the annual slapfight between "people who navigate Rust modules from the module names first" and "people who navigate Rust modules via the folders first"?

[ChrisDenton]

To be clear, I have no preference but I do have a mild dislike for churn. Anyway, I'll leave it up to the reviewer.

[workingjubilee]

I mean, I obviously can't say "churn bad" given my history¹²³. :^)

Footnotes

1. https://github.com/rust-lang/rust/pull/132574 ↩

2. https://github.com/rust-lang/rust/pull/132385 ↩

3. https://github.com/rust-lang/rust/pull/132246 ↩

[bors]

☔ The latest upstream changes (presumably #132661) made this pull request unmergeable. Please resolve the merge conflicts.

[RalfJung]

@rust-lang/libs in the end this is up to you. :)

[Amanieu]

While I personally prefer the mod.rs style, here I would prefer staying consistent with the code style of the rest of the standard library and instead fixing triagebot.

[RalfJung]

The standard library has 193 mod.rs files (find library/ -name mod.rs). libcore alone has 31 (find library/core/src -name mod.rs). So in which sense does this PR make things not consistent with the existing code style?

[Amanieu]

The standard library also has 457 directories which indicates that the prevailing style is to not use mod.rs. Anyways, I don't feel too strongly about this so r=me unless someone else feels strongly about it.

[RalfJung]

FWIW for modules which only contain a "tests" file, the module_name.rs style makes a lot of sense IMO. And AFAIK no explicit decision for either style has been made by the team, so we shouldn't read too much into a a 2/3 majority. Clearly both styles are popular.

[workingjubilee]

I

1. prefer fixing triagebot with or without this PR, tbh
2. prefer not deciding the matter on a simple "vote" or "exit poll"
3. ...truly, please, do not invite me to discuss the tyranny of the majority for the next while, I will struggle to restrain myself
4. am happy to acknowledge RalfJung's interest (more generally, wg-const-eval's interest) and thus organize this directory in a way that strikes them as convenient

considering the first and last items, I most prefer to r+ this if someone first opens an issue on the triagebot repo that it might be nice if the triagebot syntax worked for this case "automatically".

[RalfJung]

Triagebot is configured in terms of files and folders, not Rust modules. IMO it'd be strange if it worked any differently. So I've formulated the issue in a more open-ended way: rust-lang/triagebot#1855.

[workingjubilee]

Triagebot is configured in terms of files and folders, not Rust modules. IMO it'd be strange if it worked any differently. So I've formulated the issue in a more open-ended way: rust-lang/triagebot#1855

Yes, I was struggling to phrase the "automatically" there as I was considering it. Thank you.