Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize UnsafeCell::from_mut #131261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stabilize UnsafeCell::from_mut #131261

wants to merge 1 commit into from

Conversation

clarfonthey
Copy link
Contributor

@clarfonthey clarfonthey commented Oct 4, 2024 •
edited
Loading

Closes #111645.
FCP: #111645 (comment)

Note that because const_mut_refs and const_refs_to_cell was stabilized, it's okay to const-stabilize this method as well.

@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 4, 2024
@tgross35
Copy link
Contributor

tgross35 commented Oct 4, 2024

This seems fine to me, but FCP did not include const stabilization so

r? libs-api

Cc @rust-lang/wg-const-eval

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Oct 4, 2024
@rustbot rustbot assigned dtolnay and unassigned tgross35 Oct 4, 2024
@RalfJung
Copy link
Member

RalfJung commented Oct 4, 2024 •
edited
Loading

No objections from the const-eval side.

But yeah the question is whether libs-api wants to retroactively add const to the FCP or start a new FCP.

@RalfJung RalfJung added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Oct 4, 2024
@dtolnay
Copy link
Member

dtolnay commented Oct 6, 2024

I am not unilaterally approving a const stabilization on top of the team FCP from #111645. But if there is quorum in the next libs-api meeting or enough 👍 from @rust-lang/libs-api, I think this PR can be merged without a whole new FCP.

@dtolnay dtolnay added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
I-libs-api-nominated Nominated for discussion during a libs-api team meeting. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for UnsafeCell::from_mut
5 participants
@clarfonthey @rustbot @tgross35 @RalfJung @dtolnay