Stabilize UnsafeCell::from_mut
#131261
Merged
Stabilize UnsafeCell::from_mut
#131261
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
clarfonthey
force-pushed
the
unsafe-cell-from-mut
branch
from
874aee7
to
6828a1e
Compare
|
This seems fine to me, but FCP did not include r? libs-api Cc @rust-lang/wg-const-eval |
rustbot
added
the
T-libs-api
|
No objections from the const-eval side. But yeah the question is whether libs-api wants to retroactively add |
RalfJung
added
the
I-libs-api-nominated
|
I am not unilaterally approving a |
dtolnay
approved these changes
Oct 6, 2024
dtolnay
added
S-waiting-on-team
|
Discussed in libs-api meeting. @bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 5, 2024
…r=m-ou-se Stabilize `UnsafeCell::from_mut` Closes rust-lang#111645. FCP: rust-lang#111645 (comment) Note that because `const_mut_refs` and `const_refs_to_cell` was stabilized, it's okay to const-stabilize this method as well.
|
The "cfg_attr(bootstrap" is no longer needed.
|
|
... But now the PR already got rolled up so please don't change it any more. Once it lands please file a follow up PR removing the unnecessary attribute.
|
tgross35
removed
the
I-libs-api-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 6, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#131261 (Stabilize `UnsafeCell::from_mut`) - rust-lang#131405 (bootstrap/codegen_ssa: ship llvm-strip and use it for -Cstrip) - rust-lang#132077 (Add a new `wide-arithmetic` feature for WebAssembly) - rust-lang#132562 (Remove the `wasm32-wasi` target from rustc) - rust-lang#132660 (Remove unused errs.rs file) Failed merges: - rust-lang#131721 (Add new unstable feature `const_eq_ignore_ascii_case`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 6, 2024
Rollup merge of rust-lang#131261 - clarfonthey:unsafe-cell-from-mut, r=m-ou-se Stabilize `UnsafeCell::from_mut` Closes rust-lang#111645. FCP: rust-lang#111645 (comment) Note that because `const_mut_refs` and `const_refs_to_cell` was stabilized, it's okay to const-stabilize this method as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #111645.
FCP: #111645 (comment)
Note that because
const_mut_refsandconst_refs_to_cellwas stabilized, it's okay to const-stabilize this method as well.