Use npm ci instead of install

[h-michael]

fix #422

npm install is always recreate package-lock.json.
So we might use npm ci with install-code

https://docs.npmjs.com/cli/ci.html#description

[matklad]

LGTM, but I know nothing about npm. If no one thinks this will break in some cases, I'll merge!

[DJMcNab]

I'm not sure that this is a good change - I think npm ci deletes node_modules, which is bad.

This means we reinstall node_modules on every cargo install-code

[h-michael]

@DJMcNab Ok, how about this?

[matklad]

So, npm either ignores lockfile, or purges node_modules completely? 🤦‍♂️

[matklad]

FWIW, I'd personally will be more confident with npm ci: cargo install-code is not something which should be executed frequently, and I'd love to be sure that folks get exacetly the packages from package-lock.json.

[h-michael]

I'm not sure that this is a good change - I think npm ci deletes node_modules, which is bad.

Uh, but I think we might use npm ci instead of npm install.
npm install always re-resolves package dependency and it's bit slow.
npm ci don't resolves package dependency.
Surely npm ci delete node_modules, but npm caches packages to .npm directory.
So I think npm ci isn't slow.

[DJMcNab]

In a development cycle, I frequently run cargo install-code as its the easiest way for me to test out the new changes without making a full test. Maybe we should have a cargo install-lsp which forgoes installing the extension altogether.

[matklad]

@DJMcNab would VSCode's F5 command work for you during development? My understanding is that after #566 just hitting F5 runs a new vscode instance with freshly-built extension and freshly-build ra-analyzer?

[DJMcNab]

I forgot we had that set up. However, I still want to use rust analyzer when developing it, so I still want the release version of ra_lsp_server installed and up to date as well..

[matklad]

so I still want the release version of ra_lsp_server installed and up to date as well..

For that, I personally do cargo install --path crates/ra_lsp_server/ --force. #618 should make that even better.

[DJMcNab]

Fair enough - cargo install-code as a blessed subcommand made me not even consider that as an option 🤦‍♂️.

[kjeremy]

Aren't we supposed to use vsce package? https://code.visualstudio.com/api/working-with-extensions/publishing-extension

[matklad]

that’s what install-code uses, yeah

bors r+

[bors]

Build succeeded

• continuous-integration/travis-ci/push