Skip to content

Extension debug #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2019
Merged

Extension debug #566

merged 3 commits into from
Jan 18, 2019

Conversation

andrew-w-ross
Copy link
Contributor

I was having trouble getting started with contributing to rust-analyzer.

This PR adds debugging for both the vscode extension and the rls server and instructions on how to get setup.

…UG is set

Changed presentation from clear to reveal silent
Removed the vscode gitignore entry
Added debugging documentation
Added tasks and launch configs
…extension-debug

Pulling updates from upstream
@matklad
Copy link
Member

matklad commented Jan 18, 2019

Awesome 😍 !

Could you use this instead of adding the gif directly to the repository?

Changed gif link
@andrew-w-ross
Copy link
Contributor Author

@matklad There you go.

@matklad
Copy link
Member

matklad commented Jan 18, 2019

bors r+

👍

bors bot added a commit that referenced this pull request Jan 18, 2019
566: Extension debug r=matklad a=andrew-w-ross

I was having trouble getting started with contributing to `rust-analyzer`.

This PR adds debugging for both the vscode extension and the rls server and instructions on how to get setup.


Co-authored-by: Andrew Ross <rossirsa@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 18, 2019

Build succeeded

@bors bors bot merged commit 27231ba into rust-lang:master Jan 18, 2019
@kjeremy
Copy link
Contributor

kjeremy commented Jan 18, 2019

The lldb extension doesn't work well on windows, Native Debug (webfreak.debug extension) may be a better cross-platform option.

@andrew-w-ross
Copy link
Contributor Author

@kjeremy Let me see if I can't get CodeLLDB working on windows. Native Debug hasn't seen an update since March 2018 so it might be abandonware.

bors bot added a commit that referenced this pull request Jan 19, 2019
570: Add .vscode/settings.json to .gitignore r=matklad a=DJMcNab

#566 removed `.vscode` from .gitignore

I want this because I usually use `formatOnSave`, but until our rustfmt integration properly supports rustfmt.toml, this only leads to spurious diffs, so I disable it in this repository. 

We can always remove this later if we have any settings we are desperate to set.

Co-authored-by: DJMcNab <36049421+djmcnab@users.noreply.github.com>
@DJMcNab
Copy link
Contributor

DJMcNab commented Jan 19, 2019

Just as note, adding that gif directly into the repository means it has to be downloaded on every clone, even though it should never been seen. Unfortunately, I'm not sure there's anything that can be done now, unless we rewrite history, which seems bad.

However, if we want to do so, now is our best chance whilst it is still fresh.

@matklad
Copy link
Member

matklad commented Jan 19, 2019

Ther's no gif in the repository ;)

@DJMcNab
Copy link
Contributor

DJMcNab commented Jan 19, 2019

@matklad
Copy link
Member

matklad commented Jan 19, 2019

Ouch, of course you are correct, thank you so much for spotting this!

Will rewrite the history now!

@matklad
Copy link
Member

matklad commented Jan 19, 2019

Blast it! I've tagged this change for the guide as well TT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants