cargo code-install makes package.json and package-lock.json diff

[h-michael]

When I execute cargo install-code, it makes code difference at package.json and package-lock.json like this.

--- a/editors/code/package-lock.json
+++ b/editors/code/package-lock.json
@@ -22,10 +22,10 @@
             "integrity": "sha512-FBHEW6Jf5TB9MGBgUUA9XHkTbjXYfAUjY43ACMfmdMRHniyoMHjHjzD50OK8LGDWQwp4rWEsIq5kEqq7rvIM1g==",
             "dev": true,
             "requires": {
-                "fast-deep-equal": "2.0.1",
-                "fast-json-stable-stringify": "2.0.0",
-                "json-schema-traverse": "0.4.1",
-                "uri-js": "4.2.2"
+                "fast-deep-equal": "^2.0.1",
+                "fast-json-stable-stringify": "^2.0.0",
+                "json-schema-traverse": "^0.4.1",
+                "uri-js": "^4.2.2"
             }
         },
         "ansi-cyan": {
@@ -70,7 +70,7 @@
             "integrity": "sha1-2CIM9GYIFSXv6lBhTz3mUU36WPE=",
             "dev": true,
             "requires": {
-                "buffer-equal": "1.0.0"
+                "buffer-equal": "^1.0.0"
             }
         },
         "argparse": {
@@ -79,7 +79,7 @@
             "integrity": "sha512-o5Roy6tNG4SL/FOkCAN6RzjiakZS25RLYFrcMttJqbdd8BWrnA+fGz57iN5Pb06pvBGvl5gQ0B48dJlslXvoTg==",
             "dev": true,
             "requires": {
-                "sprintf-js": "1.0.3"
+                "sprintf-js": "~1.0.2"
             }
         },
...

diff --git a/editors/code/package.json b/editors/code/package.json
index e0db3c33..9b8f6351 100644
--- a/editors/code/package.json
+++ b/editors/code/package.json
@@ -214,4 +214,4 @@
             }
         ]
     }
-}
\ No newline at end of file
+}

code --version
1.30.1
dea8705087adb1b5e5ae1d9123278e178656186a
x64

node -v
v10.11.0

npm --version
6.5.0

[DJMcNab]

I think npm cannot make it's mind up about their lockfile format, which makes this very difficult to avoid, unfortunately. It's not really our job to fix this here, so I'm inclined to close.

We could make cargo install-code call git checkout HEAD -- package-lock.json (https://stackoverflow.com/questions/7147270/hard-reset-of-a-single-file), but that's a bit ugly.

Are you sure that that diff in package.json is from cargo install-code, or do you have files.insertFinalNewline set in vscode and inadvertently saved in package.json - I get no diff in package.json?