Add install-lsp subcommand #618
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Jan 23, 2019
.cargo/config
Outdated
| gen-tests = "run --package tools --bin tools -- gen-tests" | ||
| # Installs ra-lsp-server | ||
| install-lsp = "run --package tools --bin tools -- install-lsp" |
There was a problem hiding this comment.
I think this could be just install --package ra_lsp_server --force, without code changes?
h-michael
force-pushed
the
install-lsp
branch
from
163a7eb to
8620429
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 23, 2019
618: Add install-lsp subcommand r=matklad a=h-michael related #617 (comment) Co-authored-by: Hirokazu Hata <h.hata.ai.t@gmail.com>
h-michael
force-pushed
the
install-lsp
branch
from
8620429 to
7bd38fb
Compare
Canceled |
|
bors delegate+ |
|
✌️ h-michael can now approve this pull request |
|
@matklad sorry, re-fixed. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 23, 2019
617: Use npm ci instead of install r=matklad a=h-michael fix #422 `npm install` is always recreate `package-lock.json`. So we might use `npm ci` with `install-code` https://docs.npmjs.com/cli/ci.html#description 618: Add install-lsp subcommand r=matklad a=h-michael related #617 (comment) Co-authored-by: Hirokazu Hata <h.hata.ai.t@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #617 (comment)