Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new test interface definitions #332

Merged
merged 3 commits into from
May 1, 2019
Merged

Use new test interface definitions #332

merged 3 commits into from
May 1, 2019

Conversation

jacobperron
Copy link
Member

@jacobperron jacobperron added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels May 1, 2019
@jacobperron jacobperron mentioned this pull request May 1, 2019
Closed
dirk-thomas
dirk-thomas reviewed May 1, 2019
View reviewed changes
rclpy/test/test_node.py Outdated Show resolved Hide resolved
@jacobperron jacobperron mentioned this pull request May 1, 2019
Merged
@sloretz
Copy link
Contributor

sloretz commented May 1, 2019

@jacobperron FYI it looks like there's a small merge conflict (git doesn't know which order to add the new import statements)

@jacobperron
Use new test interface definitions
c484961 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Fix lint
88c65ad 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Rename variables
7287f89 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

@sloretz I've rebased and also updated the changes from master to use the new service name BasicTypes.

@jacobperron jacobperron merged commit d8948bb into master May 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the add_test_interface_files branch May 1, 2019 23:32
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label May 1, 2019
@sloretz sloretz mentioned this pull request May 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

@sloretz sloretz sloretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobperron @sloretz @dirk-thomas