Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new interface definitions #350

Merged
merged 14 commits into from
May 1, 2019
Merged

Use new interface definitions #350

merged 14 commits into from
May 1, 2019

Conversation

jacobperron
Copy link
Member

@jacobperron jacobperron commented Apr 30, 2019 •
edited by dirk-thomas
Loading

Interface definitions for testing have been consolidated into a common package, test_interface_files.
They have been refactored in an effort to reduce the number of interfaces and also renamed to follow IDL terminology.

This change switches over the tests to use the new interface definitions.

Connects to ros2/rcl_interfaces#58

@jacobperron jacobperron added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) labels Apr 30, 2019
@jacobperron
Copy link
Member Author

jacobperron commented Apr 30, 2019 •
edited
Loading

Preliminary test of test_communications to catch any issues:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
    I realized I should also update test_cli_remapping and test_security for a full CI to pass.

EDIT: re-triggered with updates to test_security.

@jacobperron jacobperron added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Apr 30, 2019
dirk-thomas
dirk-thomas approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (up to the current state)

@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels May 1, 2019
@jacobperron jacobperron mentioned this pull request May 1, 2019
Closed
@jacobperron
Replace Primitives with BasicTypes
49c6ece 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Replace StaticArrayPrimitives with Arrays
35571d8 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Replace BoundedArrayPrimitives with BoundedSequences
1798765 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Replace DynamicArrayPrimitives with UnboundedSequences
5643753 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Replace nested sequence and array message types with MultiNested
3ac7b23 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Update FieldsWithSameType.msg
c6aa1c0 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Update test_message_serialization.cpp
6a6c8ee 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Fix compile issues
f2a479d 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Add tests for Constants.msg and Defaults.msg
2886c18 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Update expected buffer length for serialized message
17880d2 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Add test for Strings.msg for C
cfc696c 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
cleanup
31efd83 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Update test_security package to use new interface definitions
86f5df6 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

Rebased on master to get launch testing changes.

@jacobperron
Copy link
Member Author

CI retriggered including changes in the following connected PRs:

@jacobperron
Use BasicTypes for checking message serialization size
c1c41b2 
It seems that BoundedSequences does not have a consistent size between tests.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

jacobperron commented May 1, 2019 •
edited
Loading

@dirk-thomas PTAL at c1c41b2

I'm not sure why, but BoundedSequences.msg has different serialized sizes dependent on the RMW implementation. BasicTypes.msgs appears to be consistent.

@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas
Copy link
Member

https://ci.ros2.org/job/ci_windows/6701/warnings43Result/

It looks like the min value of int32 needs the same treatment as the 64 bit one.

@jacobperron
Copy link
Member Author

jacobperron commented May 1, 2019 •
edited by dirk-thomas
Loading

It looks like the min value of int32 needs the same treatment as the 64 bit one.

Fix ros2/rosidl#375 and CI:
Build Status

@jacobperron jacobperron merged commit adfcf04 into master May 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the add_test_interface_files branch May 1, 2019 23:33
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobperron @dirk-thomas