Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interfaces for logging service. #154

Merged
merged 6 commits into from
Apr 17, 2023

Conversation

llapx
Copy link
Contributor

@llapx llapx commented Mar 8, 2023

No description provided.

@llapx
Copy link
Contributor Author

llapx commented Mar 8, 2023

this PR is a component of #ros2/rclcpp#2122

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fujitatomoya
Copy link
Collaborator

@llapx as interface, it looks good to me. just requesting update https://github.com/ros2/rcl_interfaces/blob/rolling/rcl_interfaces/README.md with additional message and service files.

@llapx
Copy link
Contributor Author

llapx commented Mar 14, 2023

@llapx as interface, it looks good to me. just requesting update https://github.com/ros2/rcl_interfaces/blob/rolling/rcl_interfaces/README.md with additional message and service files.

Updated, thanks.

@fujitatomoya
Copy link
Collaborator

@gbiggs requesting review on this.

@fujitatomoya
Copy link
Collaborator

I am not sure who to ask the review, since @gbiggs (maintainer according to pacakge.xml) not responding?

CC: @ros2/dev

@fujitatomoya
Copy link
Collaborator

@iuhilnehc-ynos can you review this?

Copy link
Member

@aprotyas aprotyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments, not an exhaustive review by any means

rcl_interfaces/README.md Outdated Show resolved Hide resolved
rcl_interfaces/README.md Outdated Show resolved Hide resolved
rcl_interfaces/msg/LoggerLevel.msg Outdated Show resolved Hide resolved
llapx and others added 3 commits April 4, 2023 10:19
Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
@Barry-Xu-2018
Copy link

Rebase was done.

@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Signed-off-by: Barry Xu <barry.xu@sony.com>
Comment on lines 12 to 13
# logger level: UNKNOWN, DEBUG, INFO, WARN, ERROR, FATAL
# 0 10 20 30 40 50
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# logger level: UNKNOWN, DEBUG, INFO, WARN, ERROR, FATAL
# 0 10 20 30 40 50

These are now specified as constants, so the comment isn't needed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I remove them.

Signed-off-by: Barry Xu <barry.xu@sony.com>
Comment on lines 61 to 63
* [SetParametersAtomically](srv/SetParametersAtomically.srv): Add or change all parameters in a list or none at all.
* [GetLoggerLevels](srv/GetLoggerLevels.srv): Get the logger levels of a specific list of nodes which are in the same process space.
* [SetLoggerLevels](srv/SetLoggerLevels.srv): Change a list of logger levels of nodes which are in the same process space.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [SetParametersAtomically](srv/SetParametersAtomically.srv): Add or change all parameters in a list or none at all.
* [GetLoggerLevels](srv/GetLoggerLevels.srv): Get the logger levels of a specific list of nodes which are in the same process space.
* [SetLoggerLevels](srv/SetLoggerLevels.srv): Change a list of logger levels of nodes which are in the same process space.
* [SetParametersAtomically](srv/SetParametersAtomically.srv): Add or change all parameters in a list or none at all
* [GetLoggerLevels](srv/GetLoggerLevels.srv): Get the logger levels of a specific list of nodes which are in the same process space
* [SetLoggerLevels](srv/SetLoggerLevels.srv): Change a list of logger levels of nodes which are in the same process space

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@@ -0,0 +1,13 @@
# All available logger levels
Copy link
Contributor

@clalancette clalancette Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should note here that this will match what is in rcutils. Maybe something like:

Suggested change
# All available logger levels
# All available logger levels; these correspond to the enum in rcutils/logger.h

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

string name

# The logger level
uint8 level
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this need to be the same size as what rcutils can represent? In https://github.com/ros2/rcutils/blob/04aa9804feb46403f0058f4b089134a6985e19d3/include/rcutils/logging.h#L171-L179 , it is an enum, which I think is at least 4 bytes (uint32).

Suggested change
uint8 level
uint32 level

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

rcl_interfaces/README.md Outdated Show resolved Hide resolved
@fujitatomoya
Copy link
Collaborator

@Barry-Xu-2018 i was trying to push the fix but no permission. can you check the unresolved comments?

Signed-off-by: Barry Xu <barry.xu@sony.com>
@Barry-Xu-2018
Copy link

I updated codes based on review comments. @fujitatomoya
@clalancette Please review again.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants