Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging service support #1102

Merged
merged 5 commits into from
Apr 18, 2023
Merged

Logging service support #1102

merged 5 commits into from
Apr 18, 2023

Conversation

Barry-Xu-2018
Copy link
Contributor

@Barry-Xu-2018 Barry-Xu-2018 commented Mar 30, 2023 •
edited
Loading

Address ros2/ros2#1355

Depend on ros2/rcl_interfaces#154

The commit Add the lock for get/set logger (423b471) can be reverted after ros2/rcutils#397 is implemented.

@fujitatomoya fujitatomoya self-assigned this Mar 31, 2023
iuhilnehc-ynos
iuhilnehc-ynos approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@iuhilnehc-ynos iuhilnehc-ynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two minor suggestions though.

rclpy/rclpy/__init__.py Outdated Show resolved Hide resolved
rclpy/rclpy/node.py Outdated Show resolved Hide resolved
@fujitatomoya fujitatomoya mentioned this pull request Apr 3, 2023
Closed
6 tasks
fujitatomoya
fujitatomoya approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with minor comments.

rclpy/rclpy/__init__.py Outdated Show resolved Hide resolved
rclpy/src/rclpy/_rclpy_logging.cpp Show resolved Hide resolved
rclpy/src/rclpy/_rclpy_logging.cpp Show resolved Hide resolved
@fujitatomoya
Copy link
Collaborator

@Barry-Xu-2018 can you start CI with related to PRs?

@Barry-Xu-2018
Copy link
Contributor Author

@iuhilnehc-ynos Could you help to run CI ?

@iuhilnehc-ynos
Copy link
Contributor

Depend on ros2/rcl_interfaces#154

Please rebase it first as there is GetTypeDescription.srv updated in the rcl_interfaces.

@Barry-Xu-2018
Copy link
Contributor Author

@iuhilnehc-ynos Rebase was done for ros2/rcl_interfaces#154.

@iuhilnehc-ynos
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya mentioned this pull request Apr 4, 2023
Merged
@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

wjwwood
wjwwood approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I think we're triaging remaining PRs with ci (since things have changed a lot in the last 11days we need to double check these ones) so hopefully once I review the rclcpp one we can get this in.

@Barry-Xu-2018 @clalancette
Implement logging service
bb8721a 
Signed-off-by: Barry Xu <barry.xu@sony.com>
@Barry-Xu-2018 @clalancette
Add the lock for get/set logger
3499ba2 
Signed-off-by: Barry Xu <barry.xu@sony.com>
@Barry-Xu-2018 @clalancette
Add static for global lock variable
80d533c 
Signed-off-by: Barry Xu <barry.xu@sony.com>
@Barry-Xu-2018 @clalancette
Address review comments
f2c34cb 
Signed-off-by: Barry Xu <barry.xu@sony.com>
@Barry-Xu-2018 @clalancette
Update the descrption of function parameter
fe9760e 
Signed-off-by: Barry Xu <barry.xu@sony.com>
@Barry-Xu-2018 Barry-Xu-2018 mentioned this pull request Apr 18, 2023
Merged
@clalancette clalancette merged commit 376e59e into ros2:rolling Apr 18, 2023
@clalancette clalancette mentioned this pull request Oct 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@iuhilnehc-ynos iuhilnehc-ynos iuhilnehc-ynos approved these changes

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees

@fujitatomoya fujitatomoya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Barry-Xu-2018 @fujitatomoya @iuhilnehc-ynos @wjwwood @clalancette