-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging service support #1102
Logging service support #1102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, two minor suggestions though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with minor comments.
@Barry-Xu-2018 can you start CI with related to PRs? |
@iuhilnehc-ynos Could you help to run CI ? |
Please rebase it first as there is |
@iuhilnehc-ynos Rebase was done for ros2/rcl_interfaces#154. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, I think we're triaging remaining PRs with ci (since things have changed a lot in the last 11days we need to double check these ones) so hopefully once I review the rclcpp one we can get this in.
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
7747a77
to
fe9760e
Compare
Address ros2/ros2#1355
Depend on ros2/rcl_interfaces#154
The commit
Add the lock for get/set logger
(423b471) can be reverted after ros2/rcutils#397 is implemented.