Skip to content

fix(nav2_theta_star_planner): Correct typo in CMakeLists ament_export_dependencies #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2025
Merged

fix(nav2_theta_star_planner): Correct typo in CMakeLists ament_export_dependencies #5514

merged 1 commit into from
Sep 7, 2025

Conversation

@JPLDevMaster
Copy link
Contributor

@JPLDevMaster JPLDevMaster commented Sep 6, 2025

Basic Info

Info Please fill out this column
Ticket(s) this addresses N/A
Primary OS tested on Ubuntu 22.04 LTS
Robotic platform tested on N/A (build fix)
Does this PR contain AI generated software? (No, just a newline really)
Was this PR description generated by AI software? No

Description of contribution in a few bullet points

  • I fixed a typo in the CMakeLists.txt file from the nav2_theta_star_planner package where the nav2_costmap_2d and nav2_util were written together (without a newline).

Description of documentation updates required from your changes

N/A

Description of how this change was tested

  • Performed a clean build using colcon build --symlink-install.

Future work that may be required in bullet points

N/A

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

@JPLDevMaster
Copy link
Contributor Author

JPLDevMaster commented Sep 6, 2025

Hi!
I am using a ROS2 Humble distribution and therefore tried to create a similar PR to humble_main, however I saw the comment from the mergify bot and am therefore creating this PR to main. Sorry for any inconvenience!

@codecov
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JPLDevMaster JPLDevMaster force-pushed the fix/main-cmakelists-typo branch 2 times, most recently from 4a69b13 to 33e348a Compare September 6, 2025 16:39
@JPLDevMaster
fix(nav2_theta_star_planner): Correct typo in CMakeLists ament_export…
38b3d9b 
…_dependencies

Signed-off-by: JPLDevMaster <joao.penha.lopes@tecnico.ulisboa.pt>
@JPLDevMaster JPLDevMaster force-pushed the fix/main-cmakelists-typo branch from 33e348a to 38b3d9b Compare September 6, 2025 16:42
@SteveMacenski SteveMacenski merged commit ab4aaf8 into ros-navigation:main Sep 7, 2025
16 checks passed
@JPLDevMaster
Copy link
Contributor Author

JPLDevMaster commented Sep 8, 2025

Thanks! Could this please be backported to humble?

@SteveMacenski
Copy link
Member

SteveMacenski commented Sep 8, 2025

I don’t think this is a problem on Humble: https://github.com/ros-navigation/navigation2/blob/humble/nav2_theta_star_planner/CMakeLists.txt

@JPLDevMaster
Copy link
Contributor Author

JPLDevMaster commented Sep 8, 2025

Sorry, I meant humble_main instead of humble. I assume the difference between them is the backporting of new features to be compatible with the Humble distro, right?
I am working with ROS2 Humble but I need to integrate several new features that are available on humble_main, but not humble.

@SteveMacenski
Copy link
Member

SteveMacenski commented Sep 9, 2025

Done: https://github.com/ros-navigation/navigation2/blob/humble_main/nav2_theta_star_planner/CMakeLists.txt

@JPLDevMaster
Copy link
Contributor Author

JPLDevMaster commented Sep 9, 2025

Thank you!

silanus23 pushed a commit to silanus23/navigation2 that referenced this pull request Sep 18, 2025
@JPLDevMaster @silanus23
fix(nav2_theta_star_planner): Correct typo in CMakeLists ament_export…
bdd1089 
…_dependencies (ros-navigation#5514)

Signed-off-by: JPLDevMaster <joao.penha.lopes@tecnico.ulisboa.pt>
SteveMacenski pushed a commit that referenced this pull request Sep 19, 2025
@JPLDevMaster @SteveMacenski
fix(nav2_theta_star_planner): Correct typo in CMakeLists ament_export…
b0af0ad 
…_dependencies (#5514)

Signed-off-by: JPLDevMaster <joao.penha.lopes@tecnico.ulisboa.pt>
SteveMacenski added a commit that referenced this pull request Sep 20, 2025
@SteveMacenski @emersonknapp
@tonynajjar @JPLDevMaster @Sushant-Chavan
Kilted Sync Sept 19, 2025 1.4.2 (#5539)
3478bad 
* Return early from edge interpolation for zero-length edges (#5453)

* Return early from edge interpolation for zero-length edges

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

* Move the check and add a test

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

---------

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

* nav2_route vizualization marker rendering performance improvement (#5452)

* nav2_route vizualization marker use sphere_list and line_list for rendering performance

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

* Fix unit test and break out magic constants into named values

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

---------

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

* Fix dynamic param SmacPlannerLattice  (#5478)

* Fix SmacPlannerLattice dynamic parameter early exit

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* remove comment

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Fix duplicate poses with computePlanThroughPoses (#5488)

* fix-duplicate-poses

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Update nav2_planner/src/planner_server.cpp

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Fix seg fault (#5501)

* Fix segmentation fault

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fix linting

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Route graph vis fixes: Fixes regressions from #5452 (#5507)

* Fixes for route graph

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix route graph vis

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Removing openMP dep on MPPI (#5506)

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Add debug topic to visualize whether MPPI critic has an effect on costs (#5485)

* Publish criticsStats

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* linting

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* change header to stamp

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* make unique_pointer

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* typo

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Add readme

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* add to readme

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fixes

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fix(nav2_theta_star_planner): Correct typo in CMakeLists ament_export_dependencies (#5514)

Signed-off-by: JPLDevMaster <joao.penha.lopes@tecnico.ulisboa.pt>

* Fix/dependency and header (#5520)

* Add missing dependency declaration

Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>

* Remove unused header

Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>

---------

Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>

* bump to 1.4.2 for kilted release

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Adding critic manager for refactor

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Update API refactor

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* API updates

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix formatting issues in critic_manager.hpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Signed-off-by: JPLDevMaster <joao.penha.lopes@tecnico.ulisboa.pt>
Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com>
Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>
Co-authored-by: João Penha Lopes <123633705+JPLDevMaster@users.noreply.github.com>
Co-authored-by: Sushant Chavan <sushant.chavan@idealworks.com>
BCKSELFDRIVEWORLD pushed a commit to BCKSELFDRIVEWORLD/navigation2 that referenced this pull request Sep 23, 2025
@JPLDevMaster @BCKSELFDRIVEWORLD
fix(nav2_theta_star_planner): Correct typo in CMakeLists ament_export…
272d61e 
…_dependencies (ros-navigation#5514)

Signed-off-by: JPLDevMaster <joao.penha.lopes@tecnico.ulisboa.pt>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JPLDevMaster @SteveMacenski