Skip to content

Conversation

@emersonknapp
Copy link
Contributor

Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on Ubuntu
Robotic platform tested on Gazebo simulation of Polymath autonomy
Does this PR contain AI generated software? No
Was this PR description generated by AI software? No

Description of contribution in a few bullet points

Route graph visualization marker rendering performance improvement. Doesn't change end behavior.

  • Use SPHERE_LIST for all of the nodes
  • Use LINE_LIST for all of the edges
  • Keep the text IDs the same, but put them in separate namespaces for separate visibility toggling

Description of documentation updates required from your changes

None

Description of how this change was tested

Future work that may be required in bullet points

N/A

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

@emersonknapp emersonknapp force-pushed the emerson/route-graph-viz-performance branch from 7389578 to eb18641 Compare August 13, 2025 20:11
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test fails:

- nav2_route.UtilsTest test_to_visualization_msg_conversion (/opt/overlay_ws/src/navigation2/nav2_route/test/test_utils_and_types.cpp:132)
  <<< failure message
    /opt/overlay_ws/src/navigation2/nav2_route/test/test_utils_and_types.cpp:162
    Expected equality of these values:
      graph_msg.markers.size()
        Which is: 19
      34u
        Which is: 34
  >>>

…dering performance

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp force-pushed the emerson/route-graph-viz-performance branch from eb18641 to 8741616 Compare August 25, 2025 23:02
@emersonknapp
Copy link
Contributor Author

@SteveMacenski fixed unit test and addressed review comment

@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
nav2_route/include/nav2_route/utils.hpp 100.00% <100.00%> (+1.14%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SteveMacenski SteveMacenski merged commit 0acacb0 into ros-navigation:main Aug 26, 2025
18 checks passed
bkoensgen pushed a commit to bkoensgen/navigation2 that referenced this pull request Aug 29, 2025
…s-navigation#5452)

* nav2_route vizualization marker use sphere_list and line_list for rendering performance

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

* Fix unit test and break out magic constants into named values

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

---------

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
SteveMacenski added a commit that referenced this pull request Sep 3, 2025
* Fixes for route graph

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix route graph vis

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
armgits pushed a commit to armgits/navigation2 that referenced this pull request Sep 5, 2025
…s-navigation#5452)

* nav2_route vizualization marker use sphere_list and line_list for rendering performance

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

* Fix unit test and break out magic constants into named values

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

---------

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
armgits pushed a commit to armgits/navigation2 that referenced this pull request Sep 5, 2025
…s-navigation#5507)

* Fixes for route graph

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix route graph vis

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
armgits pushed a commit to armgits/navigation2 that referenced this pull request Sep 5, 2025
…s-navigation#5452)

* nav2_route vizualization marker use sphere_list and line_list for rendering performance

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

* Fix unit test and break out magic constants into named values

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

---------

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
armgits pushed a commit to armgits/navigation2 that referenced this pull request Sep 5, 2025
…s-navigation#5507)

* Fixes for route graph

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix route graph vis

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
silanus23 pushed a commit to silanus23/navigation2 that referenced this pull request Sep 18, 2025
…s-navigation#5452)

* nav2_route vizualization marker use sphere_list and line_list for rendering performance

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

* Fix unit test and break out magic constants into named values

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

---------

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
silanus23 pushed a commit to silanus23/navigation2 that referenced this pull request Sep 18, 2025
…s-navigation#5507)

* Fixes for route graph

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix route graph vis

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
SteveMacenski pushed a commit that referenced this pull request Sep 19, 2025
)

* nav2_route vizualization marker use sphere_list and line_list for rendering performance

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

* Fix unit test and break out magic constants into named values

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

---------

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
SteveMacenski added a commit that referenced this pull request Sep 19, 2025
* Fixes for route graph

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix route graph vis

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
SteveMacenski added a commit that referenced this pull request Sep 20, 2025
* Return early from edge interpolation for zero-length edges (#5453)

* Return early from edge interpolation for zero-length edges

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

* Move the check and add a test

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

---------

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

* nav2_route vizualization marker rendering performance improvement (#5452)

* nav2_route vizualization marker use sphere_list and line_list for rendering performance

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

* Fix unit test and break out magic constants into named values

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

---------

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

* Fix dynamic param SmacPlannerLattice  (#5478)

* Fix SmacPlannerLattice dynamic parameter early exit

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* remove comment

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Fix duplicate poses with computePlanThroughPoses (#5488)

* fix-duplicate-poses

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Update nav2_planner/src/planner_server.cpp

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Fix seg fault (#5501)

* Fix segmentation fault

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fix linting

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Route graph vis fixes: Fixes regressions from #5452 (#5507)

* Fixes for route graph

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix route graph vis

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Removing openMP dep on MPPI (#5506)

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Add debug topic to visualize whether MPPI critic has an effect on costs (#5485)

* Publish criticsStats

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* linting

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* change header to stamp

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* make unique_pointer

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* typo

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Add readme

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* add to readme

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fixes

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fix(nav2_theta_star_planner): Correct typo in CMakeLists ament_export_dependencies (#5514)

Signed-off-by: JPLDevMaster <joao.penha.lopes@tecnico.ulisboa.pt>

* Fix/dependency and header (#5520)

* Add missing dependency declaration

Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>

* Remove unused header

Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>

---------

Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>

* bump to 1.4.2 for kilted release

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Adding critic manager for refactor

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Update API refactor

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* API updates

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix formatting issues in critic_manager.hpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Signed-off-by: JPLDevMaster <joao.penha.lopes@tecnico.ulisboa.pt>
Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com>
Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>
Co-authored-by: João Penha Lopes <123633705+JPLDevMaster@users.noreply.github.com>
Co-authored-by: Sushant Chavan <sushant.chavan@idealworks.com>
BCKSELFDRIVEWORLD pushed a commit to BCKSELFDRIVEWORLD/navigation2 that referenced this pull request Sep 23, 2025
…s-navigation#5452)

* nav2_route vizualization marker use sphere_list and line_list for rendering performance

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

* Fix unit test and break out magic constants into named values

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

---------

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
BCKSELFDRIVEWORLD pushed a commit to BCKSELFDRIVEWORLD/navigation2 that referenced this pull request Sep 23, 2025
…s-navigation#5507)

* Fixes for route graph

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Fix route graph vis

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants