Fix naming for nav2_path_expiring_timer_condition_bt_node #5471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David G <david.randommail1@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
SteveMacenski
approved these changes
Aug 21, 2025
bkoensgen
pushed a commit
to bkoensgen/navigation2
that referenced
this pull request
Aug 29, 2025
…tion#5471) Signed-off-by: David G <david.randommail1@gmail.com>
adivardi
added a commit
to adivardi/opennav_coverage
that referenced
this pull request
Sep 1, 2025
adivardi
added a commit
to adivardi/opennav_coverage
that referenced
this pull request
Sep 2, 2025
SteveMacenski
pushed a commit
to open-navigation/opennav_coverage
that referenced
this pull request
Sep 3, 2025
* Migrate to Kilted (#94) * update msg for Kilted * [opennav_coverage_bt] migrate BT xml files * migrate coverage_navigator * rm error_msg from ComputeCoveragePath * use newer rostooling docker images, run test for Kilted * run linter on Kilted * use base image * Migrate to Lyrical * fix all compile errors due to wrong includes and to methods that moved from nav2_util to nav2 namespace * remove leftover declaration * fix missing assignment to class members * make Blackboard variable ID prive to the navigator to avoid clashes between navigators * Break long lines * only run CI on rolling * keep BB ID params outside navigator namespace * Add const * [.github] install rosdep before build * build nav2 from source * Update tf2 & tf2_ros headers * Migrate nodes in tests * depend on nav2_bt_navigator * Also build nav2_behavior_tree * Fix naming for nav2_path_expiring_timer_condition_bt_node see ros-navigation/navigation2#5471
armgits
pushed a commit
to armgits/navigation2
that referenced
this pull request
Sep 5, 2025
…tion#5471) Signed-off-by: David G <david.randommail1@gmail.com>
armgits
pushed a commit
to armgits/navigation2
that referenced
this pull request
Sep 5, 2025
…tion#5471) Signed-off-by: David G <david.randommail1@gmail.com> Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
silanus23
pushed a commit
to silanus23/navigation2
that referenced
this pull request
Sep 18, 2025
…tion#5471) Signed-off-by: David G <david.randommail1@gmail.com>
BCKSELFDRIVEWORLD
pushed a commit
to BCKSELFDRIVEWORLD/navigation2
that referenced
this pull request
Sep 23, 2025
…tion#5471) Signed-off-by: David G <david.randommail1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the only bt plugin that doesn't contain _bt_node as suffix to also include the suffix.
nav2_path_expiring_timer_condition -> nav2_path_expiring_timer_condition_bt_node
Although this does not affect the functionality, it ensures naming consistency across all plugins used.
Backport to Kilted, Jazzy and Humble should also be possible. (for humble also in the nav2_bringup/params for all params file nav2_path_expiring_timer_condition -> nav2_path_expiring_timer_condition_bt_node should be done)
Basic Info
Description of contribution in a few bullet points
Renamed nav2_path_expiring_timer_condition -> nav2_path_expiring_timer_condition_bt_node to ensure naming consistency across all plugins.
Description of documentation updates required from your changes
NA
Description of how this change was tested
Made changes, built and tested if a bt with this node will load and execute correctly.
Future work that may be required in bullet points
Backport?
For Maintainers:
backport-*.