Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't perform catch-up behavior in ros2_control_node #802

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tylerjw
Copy link
Contributor

@tylerjw tylerjw commented Aug 17, 2022

Signed-off-by: Tyler Weaver tyler@picknik.ai

Signed-off-by: Tyler Weaver <tyler@picknik.ai>
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
@bmagyar
Copy link
Member

bmagyar commented Sep 4, 2022

Could you please add a little bit of detail to this? 2 graphs if that's convenient or just a few numbers to illustrate why one wants to have no catch-up. It's mostly for future generations

@tylerjw
Copy link
Contributor Author

tylerjw commented Sep 4, 2022

I created this quickly when trying to help someone where when running with sim time and gazebo this loop ran at an uncontrolled rate. This cut the runaway behavior down but did not produce the expected result. This should probably just be closed and we should investigate how to make this loop work when running with sim time.

@destogl
Copy link
Member

destogl commented Sep 5, 2022

I created this quickly when trying to help someone where when running with sim time and gazebo this loop ran at an uncontrolled rate. This cut the runaway behavior down but did not produce the expected result. This should probably just be closed and we should investigate how to make this loop work when running with sim time.

Should we open an issue with description before closing this?

@JayHerpin
Copy link

JayHerpin commented Sep 6, 2024

I created this quickly when trying to help someone where when running with sim time and gazebo this loop ran at an uncontrolled rate. This cut the runaway behavior down but did not produce the expected result. This should probably just be closed and we should investigate how to make this loop work when running with sim time.

out of curiosity, is there a reason this code cant just use rclcpp::Rate with the node's clock? It seems like that would handle using sim time correctly. That also implements the "no catchup" behavior implemented here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants