Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.6.0 #196

Closed
wants to merge 1 commit into from
Closed

Bump version to 0.6.0 #196

wants to merge 1 commit into from

Conversation

torkleyy
Copy link
Contributor

No description provided.

@kvark
Copy link
Collaborator

kvark commented Oct 31, 2019

Is this just for base64? I'd rather not have a dedicated release then, for now, until we have more breaking changes accumulated.

@kvark
Copy link
Collaborator

kvark commented May 1, 2020

@CAD97 if you are interested in this, we basically need a short overview of all changes that went in since the last release. Admittedly, we are missing a tag/branch for latest 0.5 release, this is no good and need to be fixed as well. Once this little investigation is done, we can both create a branch for 0.5, and add a CHANGELOG listing at least stuff changed between 0.5 and 0.6, following up with the sections for earlier revisions later.

Also, all the pending issues that would require API changes need to be triaged for the prospect of including into this breaking release.

If you (or anyone) are willing to help with this, it would be great!

@CAD97
Copy link
Contributor

CAD97 commented May 1, 2020

Checking the source downloaded from crates-io, the published commit seems to be 6e9f7dd for 0.5.1. (Methodology: 0.5.1 was published on Apr 5. Above commit is a bors commit on Apr 5. The code landed by that merge is present. The code from the following commit, d25ea20, appears to not be present.)

That means all of the following PRs have landed but not yet been published:

If we're talking about fitting in more breaking changes, it would be great if ron could conform to the serde data format conventions for API surface, which is basically just

mod de;
mod error;
mod ser;

pub use de::{from_str, Deserializer};
pub use error::{Error, Result};
pub use ser::{to_string, Serializer};

I'll look into what's required for that.

@kvark kvark mentioned this pull request May 2, 2020
@kvark
Copy link
Collaborator

kvark commented May 2, 2020

Thank you! At the minimum, we still need to triage all the open issues to see, which of them require breaking changes and can be done.

@CAD97
Copy link
Contributor

CAD97 commented May 2, 2020

Triage

I'll be honest: poking around in ron's code, I'm starting to feel that we could (should?) just start over, especially because of #175. Specifically, migrate ron to be just about parsing the data format, and create serde_ron to handle the serde part (the way that serde_yaml uses yaml-rust).

I've already implemented a "better" parser once, and would be happy to do the implementation work to get said split design up to parity with this version.

TL;DR: I think go ahead and publish 0.6 as-is, and start work on 0.7 that's pretty much a fresh start. And apparently I'm volunteering to do the initial impl work for the 0.7 rewrite.

@kvark
Copy link
Collaborator

kvark commented May 2, 2020

Thank you for classifying the issues! Looks like we can fix #174 and indeed go ahead with 0.6.
@torkleyy any feelings about this?

And apparently I'm volunteering to do the initial impl work for the 0.7 rewrite.

That's a big task, but it looks like you are capable of accomplishing it. This is much appreciated!

@kvark kvark mentioned this pull request May 21, 2020
@kvark
Copy link
Collaborator

kvark commented May 21, 2020

Closing in favour of #234

@kvark kvark closed this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants