Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement inf, -inf and NaN handling #163

Merged
merged 1 commit into from
May 26, 2019
Merged

Implement inf, -inf and NaN handling #163

merged 1 commit into from
May 26, 2019

Conversation

artemshein
Copy link
Contributor

@artemshein artemshein commented May 10, 2019 •
edited
Loading

FIxes #159

kvark
kvark approved these changes May 10, 2019
View reviewed changes
Copy link
Collaborator

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
One suggestion is left. Also let's give @torkleyy a bit of time to check this out if they want.

src/parse.rs Outdated Show resolved Hide resolved
torkleyy
torkleyy reviewed May 11, 2019
View reviewed changes
Copy link
Contributor

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might work, but I have one concern.

src/value.rs Show resolved Hide resolved
@kvark
Copy link
Collaborator

kvark commented May 13, 2019

Please rebase instead of merge committing

torkleyy
torkleyy approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!
bors r+

bors bot added a commit that referenced this pull request May 13, 2019
@bors @artemshein
Merge #163
7a31ed9 
163: Implement inf, -inf and NaN handling r=torkleyy a=artemshein

FIxes #159

Co-authored-by: Artem Shein <artem.shein@esrlabs.com>
@torkleyy
Copy link
Contributor

Um, bors?
bors ping

@bors
Copy link
Contributor

bors bot commented May 26, 2019

pong

@torkleyy
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request May 26, 2019
@bors @artemshein
Merge #163
4f36c26 
163: Implement inf, -inf and NaN handling r=torkleyy a=artemshein

FIxes #159

Co-authored-by: Artem Shein <artem.shein@esrlabs.com>
@bors
Copy link
Contributor

bors bot commented May 26, 2019

Build succeeded

@bors bors bot merged commit 8c72672 into ron-rs:master May 26, 2019
@CAD97 CAD97 mentioned this pull request May 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

@torkleyy torkleyy torkleyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

f64::INFINITY causes panic
3 participants
@artemshein @kvark @torkleyy