Testing for RON files #197
Conversation
tests/preserve_sequence.rs
Outdated
| } | ||
|
|
||
| fn read_original(file_name: &str) -> (String) { | ||
| let input_path = format!("{}/tests/{}", env!("CARGO_MANIFEST_DIR"), file_name); |
There was a problem hiding this comment.
Why don't we just include the original with include_str! or something?
There was a problem hiding this comment.
Didn't know it exists. However, if I try, the compiler keeps complaining "error: argument must be a string literal", unless I copy the string into the function. But then the flexibility of calling various files is gone.
There was a problem hiding this comment.
What I was thinking:
fn read_original(source: &str) -> String {...}
fn test_xxx() {
let file1 = include_str!("my_file1.ron");
assert_eq!(
read_original(file1),
make_roundtrip(file1),
);
}There was a problem hiding this comment.
Ah, okay. Then the file is only read once, and processed twice. A much nicer way indeed. See 0fa9da3
tests/preserve_sequence.rs
Outdated
| .expect("Something went wrong reading the file") | ||
| } | ||
|
|
||
| fn test_sequence(file_name: &str) -> (String) { |
There was a problem hiding this comment.
perhaps this should be called test_roundtrip instead?
There was a problem hiding this comment.
Good suggestion. I though about several names (reciprocal, symmetric etc) but couldn't find a brief and correct description. See 1272b61
There was a problem hiding this comment.
Forgot to update calling functions, see update in e3ada7f Now the first example fails as the mapping order is modified, while the second example proofs the test is okay.
…ip of decoding and encoding to RON code is made.
|
Like this ? c0d52d2 |
197: Testing for RON files r=kvark a=peter-scholtens As a solution to the proposed test as mentioned in #192 I created a two functions: read_original() and test_sequence(). Using an assert equal macro various files can be tested. Two examples are given: the first one fails as the mapping sequence changes, the secvond one is correct, as the map only contains one item. Co-authored-by: Peter C. S. Scholtens <peter.scholtens@xs4all.nl>
Build failed |
|
It should fail testing on the first example1 as the sequence is not preserved. Or should this be listed as a separate bug? The second test should pass succesfully. |
…d unused use-statements.
|
thank you! |
197: Testing for RON files r=kvark a=peter-scholtens As a solution to the proposed test as mentioned in #192 I created a two functions: read_original() and test_sequence(). Using an assert equal macro various files can be tested. Two examples are given: the first one fails as the mapping sequence changes, the secvond one is correct, as the map only contains one item. Co-authored-by: Peter C. S. Scholtens <peter.scholtens@xs4all.nl>
Build succeeded |
As a solution to the proposed test as mentioned in #192 I created a two functions: read_original() and test_sequence(). Using an assert equal macro various files can be tested. Two examples are given: the first one fails as the mapping sequence changes, the secvond one is correct, as the map only contains one item.