Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be smarter about integer deserialization #157

Merged
merged 2 commits into from
Apr 14, 2019
Merged

Be smarter about integer deserialization #157

merged 2 commits into from
Apr 14, 2019

Conversation

torkleyy
Copy link
Contributor

@torkleyy torkleyy commented Apr 5, 2019

Now, deserialize_any will try to find the best representation possible.

This is not a very pretty implementation, but it should work well.

Fixes #100
Fixes #155

@torkleyy
Be smarter about integer deserialization
d25ea20 
Now, deserialize_any will try to find the best representation possible
@torkleyy torkleyy requested a review from kvark April 5, 2019 19:56
@niluxv niluxv mentioned this pull request Apr 6, 2019
Closed
azriel91
azriel91 reviewed Apr 8, 2019
View reviewed changes
Copy link

@azriel91 azriel91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To semi-trained eyes, it looks good.

Just some small questions

src/de/tests.rs Show resolved Hide resolved
tests/large_number.rs Outdated Show resolved Hide resolved
@torkleyy
Copy link
Contributor Author

Thanks for the review, addressed your comments.

@torkleyy
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Apr 14, 2019
@bors @torkleyy
Merge #157
66fc37f 
157: Be smarter about integer deserialization r=torkleyy a=torkleyy

Now, `deserialize_any` will try to find the best representation possible.

This is not a very pretty implementation, but it should work well.

Fixes #100 
Fixes #155 

Co-authored-by: Thomas Schaller <torkleyy@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 14, 2019

Build succeeded

@bors bors bot merged commit 44fcaed into ron-rs:master Apr 14, 2019
@torkleyy torkleyy deleted the nmb branch April 14, 2019 07:13
@CAD97 CAD97 mentioned this pull request May 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azriel91 azriel91 azriel91 left review comments

@kvark kvark Awaiting requested review from kvark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deserializing large serialized Value::Number fails deserialize_any treats integers as f64
2 participants
@torkleyy @azriel91