Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added possibility to make lint fail if using wrong version #2427

Closed
wants to merge 85 commits into from
Closed

Added possibility to make lint fail if using wrong version #2427

wants to merge 85 commits into from

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Sep 28, 2018 •
edited
Loading

Fixes #2074

I don't know if this is the correct way solving it or the correct name of key in configuration file.

@SwiftLintBot
Copy link

SwiftLintBot commented Sep 28, 2018 •
edited
Loading

1 Warning
⚠️ Big PR
12 Messages
📖 Linting Aerial with this PR took 2.1s vs 1.99s on master (5% slower)
📖 Linting Alamofire with this PR took 4.37s vs 4.05s on master (7% slower)
📖 Linting Firefox with this PR took 16.91s vs 14.85s on master (13% slower)
📖 Linting Kickstarter with this PR took 26.92s vs 22.58s on master (19% slower)
📖 Linting Moya with this PR took 2.52s vs 2.22s on master (13% slower)
📖 Linting Nimble with this PR took 2.5s vs 2.02s on master (23% slower)
📖 Linting Quick with this PR took 0.83s vs 0.63s on master (31% slower)
📖 Linting Realm with this PR took 4.64s vs 3.99s on master (16% slower)
📖 Linting SourceKitten with this PR took 1.45s vs 1.28s on master (13% slower)
📖 Linting Sourcery with this PR took 6.08s vs 5.3s on master (14% slower)
📖 Linting Swift with this PR took 39.07s vs 32.13s on master (21% slower)
📖 Linting WordPress with this PR took 29.05s vs 22.74s on master (27% slower)

Generated by 🚫 Danger

yhkaplan and others added 20 commits September 30, 2018 14:54
@yhkaplan
Change rule implementation to use regex
3d6030d
@yhkaplan
Automatic changes to documentation, MasterRuleList, and tests
b173350
#2422 - Specify which compiler protocol initialization rule was violated
5bf50c8
#2422 - Add CompilerProtocolInitRule violation unit test for Expressi…
2cc4dca 
…bleByIntegerLiteral protocol
#2422 - Fix CI
3189d17
#2422 - Replace ruleDescription change with a StyleViolation reason f…
22be71e 
…ield in CompilerProtocolInitRule
#2422 - Add changelog entry
78ebad7
#2422 - Fix changelog
1b71ae7
@marcelofabri
Merge pull request #2428 from biboran/compiler-protocol-init-description
5bcaa61 
#2422 - Specify which literal rule was violated for CompilerProtocolInitRule
#2423 - Fix EmptyCountRule for binary, octal and hexadecimal integer …
e9d2552 
…literals
#2423 - Update changelog
e51646a
#2423 - Update documentation
21cd4e0
@marcelofabri
Merge pull request #2430 from biboran/empty-count-fix
34f513a 
#2423 - Fix EmptyCountRule for binary, octal and hexadecimal integer literals
@marcelofabri
Merge pull request #2407 from marcelofabri/enable-static-operator
2c59827 
Enable static_operator opt-in rule in SwiftLint
@yhkaplan
Rename random rule to legacy random rule
6eda139
@yhkaplan
Correct rule kind from 'lint' to 'idiomatic'
8b12806
@yhkaplan
Refactor rule to be AST rule
d40cfc0
@yhkaplan
Update Changelog with new rule name
a3031aa
@yhkaplan
Set is more efficient
1adb275
@yhkaplan
Offset already proven to be not nil
44b57de
jpsim and others added 16 commits November 27, 2018 10:55
@jpsim
release 0.28.2
b64ead1
@norio-nomura @jpsim
Add testSimulateHomebrewTest() to IntegrationTests
efea1b7 
Motivation:

Sometimes, Homebrew bottling CI fails because it runs in the sandbox.

Modifications:

Add `testSimulateHomebrewTest()` to `IntegrationTests` that simulates test in `homebrew-core/Formula/swiftlint.rb` within sandbox.

Result:

Confirm that a test equivalent to `brew test swiftlint` will pass in the sandbox before publishing to homebrew.
@jpsim
Minor stylistic edits for homebrew integration tests
f6a1618 
also fixup Package.resolved and BoolExtensionTests
@jpsim
Remove BoolExtensionTests from LinuxMain.swift
827410a
@madcato @jpsim
Add markdown reporter (#2486)
b58c4e3
@jpsim
Fix changelog entry position
64c0b96
@jpsim
Default column to 1 in XcodeReporter output (#2488)
a944808
@jpsim
Remove CryptoSwift from Carthage submodules
068d785
@jpsim
Update latest version to support Swift 4.0-4.1.x
d83143b
@jpsim
release 0.29.0
8fc75e3
@jpsim
Add empty changelog section
f44d07d
@jpsim
Style nits
60afab8
@dirtydanee @jpsim
Add "Redundant @objc Attribute" Rule (#2270)
c4e2a38
@marcelofabri
Fix false positive in nimble_operator rule
85b61e7 
Fixes #2489
@marcelofabri
Merge pull request #2490 from marcelofabri/bugfix-2489
8f8cf84 
Fix false positive in nimble_operator rule
@Jeehut @jpsim
Vertical whitespace between cases (#2292)
9d47c34
@jpsim
Copy link
Collaborator

jpsim commented Nov 28, 2018

I wonder if this should simply be the behavior when using swiftlint_version. I suspect that people who use this don't want this error lost in SwiftLint's logs.

@kimdv
Copy link
Contributor Author

kimdv commented Nov 28, 2018

@jpsim i agree ☝️
Will change it when I’m at my Mac again 😎

Sent with GitHawk

Jeehut and others added 8 commits November 28, 2018 10:30
@Jeehut @jpsim
Multiline Brackets (#2302)
cf034c9 
* Add new multiline_literal_brackets rule with examples

* Implement rule

* Add changelog entry

* Fix CHANGELOG and rule name

* Fix tests + Update stuff after rebasing

* Add more examples & fix whitespace issue

* Address feedback from @ornithocoder

* Add multiline rules for arguments and parameters

* Fix false positives in rule multiline_parameters_brackets

* Fix false positive for trailing closures in multiline_arguments_brackets

* Add nested examples to rule multiline_arguments_brackets

* Fix more false positives in multiline_arguments_brackets rule

* Use guard where appropriate instead of if

* Update generated artifacts after rebase

* Add CHANGELOG entry for all three new rules

* Move changelog entries to new version

* Fix changelog entries position

* Move new rules to correct subfolder

* Update Rules.md file contents

* Fixup changelog

* Refactor rules
@jpsim
Only mark custom rules as enabled in your config when custom rules ar…
c3d72c2 
…e configured.
@jpsim
Fix changelog entry position
b66446c
@abdulowork @jpsim
#2435 - Make modifier_order rule rely on an explicit set of rules (#2458
efa6817 
)

* #2435 - Adjust modifier_order rule to require explicit modifier order specified to conclude a violation

* #2435 - Move modifier order rule examples to a separate file

* #2435 - Add modifier interference tests

* #2435 - Fix whitespaces

* Minor edits

* Add changelog entry
@kimdv
swiftlint_version now fails when not matching right version
0962709
@kimdv
Added possibility to make lint fail if using wrong version
ff10887
@kimdv
swiftlint_version now fails when not matching right version
af14621
@kimdv
Merge branch 'swiftlint-version-failable' of https://github.com/kimdv…
abfdf43 
…/SwiftLint into swiftlint-version-failable
@kimdv
Copy link
Contributor Author

kimdv commented Nov 29, 2018

Opened new PR as i screwed up rebase

#2491

@kimdv kimdv closed this Nov 29, 2018
@kimdv kimdv deleted the swiftlint-version-failable branch November 29, 2018 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kimdv kimdv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.