Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Validate version when linting #2074

Closed
2 tasks done
kimdv opened this issue Feb 27, 2018 · 5 comments
Closed
2 tasks done

[Feature request] Validate version when linting #2074

kimdv opened this issue Feb 27, 2018 · 5 comments
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@kimdv
Copy link
Contributor

kimdv commented Feb 27, 2018

New Issue Checklist

Rule Request

I have been thinking about some minimum version validating when linting, something like fastlane have in their fastfiles. When the version is less than the required version there will be an warning or error.

The reason behind this, can be new rules in newer versions and now all developers are aware of new versions.
@marcelofabri
Copy link
Collaborator

You can already use swiftlint_version on the configuration file.

For example:

swiftlint_version: 0.30.0
$ swiftlint
Loading configuration from '.swiftlint.yml'
Currently running SwiftLint 0.25.0 but configuration specified version 0.30.0.

@kimdv
Copy link
Contributor Author

kimdv commented Mar 27, 2018

Is there somehow we can get an inside Xcode error?

@marcelofabri
Copy link
Collaborator

Not currently. We could potentially make the script fail when that happens.

@kimdv
Copy link
Contributor Author

kimdv commented Mar 29, 2018

Or that. Make a new settings that can enable that so it is opt-in

@marcelofabri marcelofabri added the enhancement Ideas for improvements of existing features and rules. label Apr 2, 2018
@kimdv kimdv mentioned this issue Sep 28, 2018
Closed
@kimdv
Copy link
Contributor Author

kimdv commented Dec 6, 2018

Closing as PR is merged

@kimdv kimdv closed this as completed Dec 6, 2018
@benweitzman benweitzman mentioned this issue Dec 9, 2018
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcelofabri @kimdv