-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swiftlint now failed when using wrong version #2491
Swiftlint now failed when using wrong version #2491
Conversation
@jpsim open new PR here. Screwed the other one. Now using |
Can you please add a changelog entry? |
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Still needs some changes.
@jpsim thanks for feedback! I have applied it. Is there a way we could test this? |
We don't currently have tests for the Thanks! |
Opened new PR as i screwed up the other one 🤦♂️🤦♂️