Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swiftlint now failed when using wrong version #2491

Merged
merged 4 commits into from
Nov 29, 2018
Merged

Swiftlint now failed when using wrong version #2491

merged 4 commits into from
Nov 29, 2018

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Nov 29, 2018

Opened new PR as i screwed up the other one 🤦‍♂️🤦‍♂️

@kimdv
Copy link
Contributor Author

kimdv commented Nov 29, 2018

@jpsim open new PR here. Screwed the other one.

Now using queuedFatalError when printing message

@marcelofabri
Copy link
Collaborator

Can you please add a changelog entry?

@SwiftLintBot
Copy link

SwiftLintBot commented Nov 29, 2018

12 Messages
📖 Linting Aerial with this PR took 2.11s vs 2.08s on master (1% slower)
📖 Linting Alamofire with this PR took 4.45s vs 4.43s on master (0% slower)
📖 Linting Firefox with this PR took 17.16s vs 15.24s on master (12% slower)
📖 Linting Kickstarter with this PR took 27.61s vs 22.92s on master (20% slower)
📖 Linting Moya with this PR took 2.62s vs 2.46s on master (6% slower)
📖 Linting Nimble with this PR took 2.69s vs 2.24s on master (20% slower)
📖 Linting Quick with this PR took 0.76s vs 0.68s on master (11% slower)
📖 Linting Realm with this PR took 4.65s vs 4.29s on master (8% slower)
📖 Linting SourceKitten with this PR took 1.5s vs 1.4s on master (7% slower)
📖 Linting Sourcery with this PR took 5.9s vs 6.01s on master (1% faster)
📖 Linting Swift with this PR took 36.72s vs 33.9s on master (8% slower)
📖 Linting WordPress with this PR took 27.5s vs 23.31s on master (17% slower)

Generated by 🚫 Danger

Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Still needs some changes.

Source/SwiftLintFramework/Models/Configuration.swift Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@kimdv
Copy link
Contributor Author

kimdv commented Nov 29, 2018

@jpsim thanks for feedback!

I have applied it.

Is there a way we could test this?

@jpsim
Copy link
Collaborator

jpsim commented Nov 29, 2018

Is there a way we could test this?

We don't currently have tests for the swiftlint target, only SwiftLintFramework. It's worth setting up tests for the CLI executable but not here.

Thanks!

@jpsim jpsim merged commit bf97e08 into realm:master Nov 29, 2018
@kimdv kimdv deleted the feature/fail-when-swiftlint-is-not-correct-version branch November 29, 2018 20:55
sjavora pushed a commit to sjavora/SwiftLint that referenced this pull request Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants