-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added possibility to make lint fail if using wrong version #2427
Commits on Sep 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1f121b1 - Browse repository at this point
Copy the full SHA 1f121b1View commit details
Commits on Sep 26, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 71b6def - Browse repository at this point
Copy the full SHA 71b6defView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cf052d - Browse repository at this point
Copy the full SHA 6cf052dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d40889f - Browse repository at this point
Copy the full SHA d40889fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f6f667 - Browse repository at this point
Copy the full SHA 4f6f667View commit details
Commits on Sep 27, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1cedd0c - Browse repository at this point
Copy the full SHA 1cedd0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9acf8ba - Browse repository at this point
Copy the full SHA 9acf8baView commit details
Commits on Sep 28, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b0ddef9 - Browse repository at this point
Copy the full SHA b0ddef9View commit details
Commits on Sep 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 3d6030d - Browse repository at this point
Copy the full SHA 3d6030dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b173350 - Browse repository at this point
Copy the full SHA b173350View commit details
Commits on Oct 1, 2018
-
#2422 - Specify which compiler protocol initialization rule was violated
Timofey Solonin committedOct 1, 2018 Configuration menu - View commit details
-
Copy full SHA for 5bf50c8 - Browse repository at this point
Copy the full SHA 5bf50c8View commit details -
#2422 - Add CompilerProtocolInitRule violation unit test for Expressi…
…bleByIntegerLiteral protocol
Timofey Solonin committedOct 1, 2018 Configuration menu - View commit details
-
Copy full SHA for 2cc4dca - Browse repository at this point
Copy the full SHA 2cc4dcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3189d17 - Browse repository at this point
Copy the full SHA 3189d17View commit details -
#2422 - Replace ruleDescription change with a StyleViolation reason f…
…ield in CompilerProtocolInitRule
Timofey Solonin committedOct 1, 2018 Configuration menu - View commit details
-
Copy full SHA for 22be71e - Browse repository at this point
Copy the full SHA 22be71eView commit details -
Timofey Solonin committed
Oct 1, 2018 Configuration menu - View commit details
-
Copy full SHA for 78ebad7 - Browse repository at this point
Copy the full SHA 78ebad7View commit details -
Timofey Solonin committed
Oct 1, 2018 Configuration menu - View commit details
-
Copy full SHA for 1b71ae7 - Browse repository at this point
Copy the full SHA 1b71ae7View commit details
Commits on Oct 2, 2018
-
Merge pull request #2428 from biboran/compiler-protocol-init-description
#2422 - Specify which literal rule was violated for CompilerProtocolInitRule
Configuration menu - View commit details
-
Copy full SHA for 5bcaa61 - Browse repository at this point
Copy the full SHA 5bcaa61View commit details -
#2423 - Fix EmptyCountRule for binary, octal and hexadecimal integer …
…literals
Timofey Solonin committedOct 2, 2018 Configuration menu - View commit details
-
Copy full SHA for e9d2552 - Browse repository at this point
Copy the full SHA e9d2552View commit details -
Timofey Solonin committed
Oct 2, 2018 Configuration menu - View commit details
-
Copy full SHA for e51646a - Browse repository at this point
Copy the full SHA e51646aView commit details -
Timofey Solonin committed
Oct 2, 2018 Configuration menu - View commit details
-
Copy full SHA for 21cd4e0 - Browse repository at this point
Copy the full SHA 21cd4e0View commit details -
Merge pull request #2430 from biboran/empty-count-fix
#2423 - Fix EmptyCountRule for binary, octal and hexadecimal integer literals
Configuration menu - View commit details
-
Copy full SHA for 34f513a - Browse repository at this point
Copy the full SHA 34f513aView commit details -
Merge pull request #2407 from marcelofabri/enable-static-operator
Enable static_operator opt-in rule in SwiftLint
Configuration menu - View commit details
-
Copy full SHA for 2c59827 - Browse repository at this point
Copy the full SHA 2c59827View commit details
Commits on Oct 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 6eda139 - Browse repository at this point
Copy the full SHA 6eda139View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b12806 - Browse repository at this point
Copy the full SHA 8b12806View commit details -
Configuration menu - View commit details
-
Copy full SHA for d40cfc0 - Browse repository at this point
Copy the full SHA d40cfc0View commit details
Commits on Oct 14, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a3031aa - Browse repository at this point
Copy the full SHA a3031aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1adb275 - Browse repository at this point
Copy the full SHA 1adb275View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44b57de - Browse repository at this point
Copy the full SHA 44b57deView commit details -
Merge pull request #2419 from yhkaplan/random
New Rule - Legacy Random
Configuration menu - View commit details
-
Copy full SHA for 83a2ca4 - Browse repository at this point
Copy the full SHA 83a2ca4View commit details
Commits on Nov 14, 2018
-
Update CircleCI jobs to Xcode 10.1 where possible (#2462)
Update CircleCI jobs to Xcode 10.1 where possible And fix changelog formatting
Configuration menu - View commit details
-
Copy full SHA for 8966d86 - Browse repository at this point
Copy the full SHA 8966d86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09cb3ba - Browse repository at this point
Copy the full SHA 09cb3baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27714d9 - Browse repository at this point
Copy the full SHA 27714d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94dd8b4 - Browse repository at this point
Copy the full SHA 94dd8b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb38f86 - Browse repository at this point
Copy the full SHA cb38f86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64fdb99 - Browse repository at this point
Copy the full SHA 64fdb99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30808b1 - Browse repository at this point
Copy the full SHA 30808b1View commit details
Commits on Nov 18, 2018
-
Improve performance of collecting files to lint and lint cache lookups (
#2465) Performance has gotten pretty bad for complex SwiftLint configurations like the one used for Lyft's iOS code base involving lots of files in the directories being linted, large configuration files and many nested configuration files. Two main areas were particularly ripe for improvement were: 1. Collecting which files to lint 2. Lint cache lookups ### Collecting which files to lint Improve this by: * using an NSOrderedSet to remove excluded paths instead of `Array.filter` * parallelizing calls to `filesToLint` for all paths to lint and exclude * using `FileManager.subpaths(atPath:)` instead of `enumerator(atPath:)` |Change|Before|After|Speed up| |-|-|-|-| |NSOrderedSet|2.438s|0.917s|2.659x| |Parallel Flat Map|2.438s|2.248s|1.085x| |Subpaths|0.939s|0.867s|1.083x| |**Total**|**2.438s**|**0.720s**|**3.386x**| ### Lint cache lookups By using an MD5 hash of the Configuration description from CryptoSwift as the cache key instead of instead the full description, we can drastically speed up cache lookups for projects with complex SwiftLint configurations. I think the dictionary lookup for very large string keys doesn't perform very well. --- * Speed up Configuration.lintablePaths * Improve cache lookup performance by up to 10x By using an MD5 hash of the Configuration description from CryptoSwift as the cache key instead of instead the full description. * Add changelog entries * Swift 4.0 & Linux compatibility * os(Darwin) isn't a thing * Allow warnings in pod lib lint SwiftLint supports building with Swift 4.0 to 4.2. There is no version of CryptoSwift to support both Swift 4.0 and Swift 4.2. So allow warnings for now. We'll make one more Swift 4.0 compatible release, then we'll bump the build requirements to Swift 4.2 and remove the `--allow-warnings` flag.
1Configuration menu - View commit details
-
Copy full SHA for d768897 - Browse repository at this point
Copy the full SHA d768897View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99db159 - Browse repository at this point
Copy the full SHA 99db159View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4955c17 - Browse repository at this point
Copy the full SHA 4955c17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 265b4fd - Browse repository at this point
Copy the full SHA 265b4fdView commit details
Commits on Nov 19, 2018
-
This bumps the minimum version required to build SwiftLint to 4.2. The primary motivating factor to drop support for Swift 4.0-4.1.x is that SwiftLint now uses CryptoSwift, which requires 4.2. * Add changelog entry * Remove --allow-warnings flag from CocoaPods commands * Update CryptoSwift to 0.13.0 * Migrate to Swift 4.2 * Remove CircleCI tests for Swift < 4.2 * Update English and Chinese README Korean README doesn't yet have a version table like this. * Update gems * Add changelog entry for fixed compiler warnings * Update CocoaPods to 1.6.0.beta.2 To work around CocoaPods/CocoaPods#7708
Configuration menu - View commit details
-
Copy full SHA for 5901d30 - Browse repository at this point
Copy the full SHA 5901d30View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf0c7b7 - Browse repository at this point
Copy the full SHA cf0c7b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d744ac5 - Browse repository at this point
Copy the full SHA d744ac5View commit details
Commits on Nov 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for fb9d8df - Browse repository at this point
Copy the full SHA fb9d8dfView commit details -
Merge pull request #2469 from marcelofabri/use-default-equatable-impl…
…ementation Use default Equatable and Hashable implementations
Configuration menu - View commit details
-
Copy full SHA for d1dbc31 - Browse repository at this point
Copy the full SHA d1dbc31View commit details
Commits on Nov 21, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9363a3a - Browse repository at this point
Copy the full SHA 9363a3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9dc20c - Browse repository at this point
Copy the full SHA b9dc20cView commit details
Commits on Nov 22, 2018
-
Use CommonCrypto if available to compute MD5 hash (#2474)
It's significantly faster than CryptoSwift: 3% vs 19% of cached lint time for Lyft's iOS codebase. ### Before (CryptoSwift) ![CryptoSwift](https://user-images.githubusercontent.com/474794/48873531-3f2a7780-eda3-11e8-9cd9-c0ef796b061b.png) ### After (CommonCrypto) ![CommonCrypto](https://user-images.githubusercontent.com/474794/48873539-481b4900-eda3-11e8-8605-4fd009da3eb1.png)
Configuration menu - View commit details
-
Copy full SHA for db2fbad - Browse repository at this point
Copy the full SHA db2fbadView commit details -
Add
SWIFTLINT_DISABLE_SOURCEKIT
environment variable (#2473)This can be used for avoid "Test::Unit::AssertionFailedError" error in `libxpc.dylib` on calling `sourcekitd_send_request_sync` in sandbox environment.
Configuration menu - View commit details
-
Copy full SHA for ea171fb - Browse repository at this point
Copy the full SHA ea171fbView commit details -
Parallelize iterating over subpaths (#2475)
This has a very small performance improvement on multi-core machines
Configuration menu - View commit details
-
Copy full SHA for d1109da - Browse repository at this point
Copy the full SHA d1109daView commit details
Commits on Nov 24, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9a216e9 - Browse repository at this point
Copy the full SHA 9a216e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f64fc2 - Browse repository at this point
Copy the full SHA 4f64fc2View commit details
Commits on Nov 25, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f135617 - Browse repository at this point
Copy the full SHA f135617View commit details -
Pass '--sanitize=thread' for tsan CI job (#2482)
Now that we require Swift 4.2, we can use this.
Configuration menu - View commit details
-
Copy full SHA for 4f8838a - Browse repository at this point
Copy the full SHA 4f8838aView commit details
Commits on Nov 27, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 45dd66b - Browse repository at this point
Copy the full SHA 45dd66bView commit details -
Fix false positives for
explicit_init
when passing init as closure ……in multiline call (#2478) * Ignore calls with `(` before .init * Update rules documentation * Update CHANGELOG.md * Change multi-line string to single-line with explicit newlines
Configuration menu - View commit details
-
Copy full SHA for e962440 - Browse repository at this point
Copy the full SHA e962440View commit details -
Configuration menu - View commit details
-
Copy full SHA for f220e03 - Browse repository at this point
Copy the full SHA f220e03View commit details -
Fix false positive on file_name rule with specific patterns (#2418)
* Add false positive failing test to file_name rule * Fix false positive in file_name rule * Add changelog entry * Use correct name in changelog
Configuration menu - View commit details
-
Copy full SHA for 7ac9efa - Browse repository at this point
Copy the full SHA 7ac9efaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4893c2d - Browse repository at this point
Copy the full SHA 4893c2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fad2a85 - Browse repository at this point
Copy the full SHA fad2a85View commit details -
Configuration menu - View commit details
-
Copy full SHA for b64ead1 - Browse repository at this point
Copy the full SHA b64ead1View commit details -
Add
testSimulateHomebrewTest()
toIntegrationTests
Motivation: Sometimes, Homebrew bottling CI fails because it runs in the sandbox. Modifications: Add `testSimulateHomebrewTest()` to `IntegrationTests` that simulates test in `homebrew-core/Formula/swiftlint.rb` within sandbox. Result: Confirm that a test equivalent to `brew test swiftlint` will pass in the sandbox before publishing to homebrew.
Configuration menu - View commit details
-
Copy full SHA for efea1b7 - Browse repository at this point
Copy the full SHA efea1b7View commit details -
Minor stylistic edits for homebrew integration tests
also fixup Package.resolved and BoolExtensionTests
Configuration menu - View commit details
-
Copy full SHA for f6a1618 - Browse repository at this point
Copy the full SHA f6a1618View commit details -
Configuration menu - View commit details
-
Copy full SHA for 827410a - Browse repository at this point
Copy the full SHA 827410aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b58c4e3 - Browse repository at this point
Copy the full SHA b58c4e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64c0b96 - Browse repository at this point
Copy the full SHA 64c0b96View commit details -
Configuration menu - View commit details
-
Copy full SHA for a944808 - Browse repository at this point
Copy the full SHA a944808View commit details -
4
Configuration menu - View commit details
-
Copy full SHA for 068d785 - Browse repository at this point
Copy the full SHA 068d785View commit details -
Configuration menu - View commit details
-
Copy full SHA for d83143b - Browse repository at this point
Copy the full SHA d83143bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fc75e3 - Browse repository at this point
Copy the full SHA 8fc75e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f44d07d - Browse repository at this point
Copy the full SHA f44d07dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 60afab8 - Browse repository at this point
Copy the full SHA 60afab8View commit details
Commits on Nov 28, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c4e2a38 - Browse repository at this point
Copy the full SHA c4e2a38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85b61e7 - Browse repository at this point
Copy the full SHA 85b61e7View commit details -
Merge pull request #2490 from marcelofabri/bugfix-2489
Fix false positive in nimble_operator rule
Configuration menu - View commit details
-
Copy full SHA for 8f8cf84 - Browse repository at this point
Copy the full SHA 8f8cf84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d47c34 - Browse repository at this point
Copy the full SHA 9d47c34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38b0114 - Browse repository at this point
Copy the full SHA 38b0114View commit details -
* Add new multiline_literal_brackets rule with examples * Implement rule * Add changelog entry * Fix CHANGELOG and rule name * Fix tests + Update stuff after rebasing * Add more examples & fix whitespace issue * Address feedback from @ornithocoder * Add multiline rules for arguments and parameters * Fix false positives in rule multiline_parameters_brackets * Fix false positive for trailing closures in multiline_arguments_brackets * Add nested examples to rule multiline_arguments_brackets * Fix more false positives in multiline_arguments_brackets rule * Use guard where appropriate instead of if * Update generated artifacts after rebase * Add CHANGELOG entry for all three new rules * Move changelog entries to new version * Fix changelog entries position * Move new rules to correct subfolder * Update Rules.md file contents * Fixup changelog * Refactor rules
Configuration menu - View commit details
-
Copy full SHA for cf034c9 - Browse repository at this point
Copy the full SHA cf034c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3d72c2 - Browse repository at this point
Copy the full SHA c3d72c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b66446c - Browse repository at this point
Copy the full SHA b66446cView commit details -
#2435 - Make modifier_order rule rely on an explicit set of rules (#2458
Configuration menu - View commit details
-
Copy full SHA for efa6817 - Browse repository at this point
Copy the full SHA efa6817View commit details
Commits on Nov 29, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0962709 - Browse repository at this point
Copy the full SHA 0962709View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff10887 - Browse repository at this point
Copy the full SHA ff10887View commit details -
Configuration menu - View commit details
-
Copy full SHA for af14621 - Browse repository at this point
Copy the full SHA af14621View commit details -
Merge branch 'swiftlint-version-failable' of https://github.com/kimdv…
…/SwiftLint into swiftlint-version-failable
Configuration menu - View commit details
-
Copy full SHA for abfdf43 - Browse repository at this point
Copy the full SHA abfdf43View commit details